(tooling-trusted-releases) branch sbp updated: Fix a problem with e2e tests

[sb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git


The following commit(s) were added to refs/heads/sbp by this push:
     new 1182d3cd Fix a problem with e2e tests
1182d3cd is described below

commit 1182d3cd86c6b2f883164a5dcda1fa280f96eff0
Author: Sean B. Palmer <se...@miscoranda.com>
AuthorDate: Fri Apr 24 20:25:46 2026 +0100

    Fix a problem with e2e tests
---
 tests/e2e/tokens/helpers.py   | 16 ++++++++++++----
 tests/e2e/tokens/test_post.py |  9 ++-------
 2 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/tests/e2e/tokens/helpers.py b/tests/e2e/tokens/helpers.py
index a221b69f..553870d8 100644
--- a/tests/e2e/tokens/helpers.py
+++ b/tests/e2e/tokens/helpers.py
@@ -17,17 +17,25 @@
 
 from typing import Final
 
+import e2e.helpers as helpers
 from playwright.sync_api import Page
 
 TOKEN_LABEL_FOR_TESTING: Final[str] = "e2e-test-token"
 TOKENS_PATH: Final[str] = "/tokens"
 
 
-def delete_token_by_label(page: Page, label: str) -> None:
-    row = get_token_row_by_label(page, label)
-    if row.count() > 0:
-        row.get_by_role("button", name="Delete").click()
+def delete_token_by_label(page: Page, label: str) -> bool:
+    deleted = False
+    while True:
+        row = get_token_row_by_label(page, label).first
+        if row.count() == 0:
+            return deleted
+        page.once("dialog", lambda dialog: dialog.accept())
+        row.get_by_role("button", name="Revoke").click()
         page.wait_for_load_state()
+        deleted = True
+        helpers.log_in(page)
+        helpers.visit(page, TOKENS_PATH)
 
 
 def get_token_row_by_label(page: Page, label: str) -> Page:
diff --git a/tests/e2e/tokens/test_post.py b/tests/e2e/tokens/test_post.py
index 96d1b671..5645e1db 100644
--- a/tests/e2e/tokens/test_post.py
+++ b/tests/e2e/tokens/test_post.py
@@ -46,7 +46,7 @@ def test_create_token_without_label_shows_error(page_tokens_clean: Page) -> None
     expect(error_message).to_contain_text("Label is required")
 
 
-def test_delete_token_shows_success(page_tokens_clean: Page) -> None:
+def test_revoke_token_removes_token(page_tokens_clean: Page) -> None:
     page = page_tokens_clean
 
     label_input = page.locator('input[name="label"]')
@@ -57,12 +57,7 @@ def test_delete_token_shows_success(page_tokens_clean: Page) -> None:
     token_row = token_helpers.get_token_row_by_label(page, token_helpers.TOKEN_LABEL_FOR_TESTING)
     expect(token_row).to_be_visible()
 
-    token_row.get_by_role("button", name="Delete").click()
-    page.wait_for_load_state()
-
-    success_message = page.locator(".flash-message.flash-success")
-    expect(success_message).to_be_visible()
-    expect(success_message).to_contain_text("Token deleted successfully")
+    token_helpers.delete_token_by_label(page, token_helpers.TOKEN_LABEL_FOR_TESTING)
 
     token_row = token_helpers.get_token_row_by_label(page, token_helpers.TOKEN_LABEL_FOR_TESTING)
     expect(token_row).to_have_count(0)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org