You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/16 17:05:32 UTC
[GitHub] [hive] sunchao opened a new pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x
sunchao opened a new pull request #2080:
URL: https://github.com/apache/hive/pull/2080
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This changes `getTable`, `getTableObjectsByName` and `tableExists` in `HiveMetastoreClient` to use `get_table` instead of `get_table_req` introduced in HIVE-15062.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
[HIVE-15062](https://issues.apache.org/jira/browse/HIVE-15062) introduced a backward-incompatible change by replacing `get_table` with `get_table_req`. As consequence, when HMS client w/ version > 2.3 interacts with a HMS w/ version < 2.3, errors will occur with the following message:
```
AnalysisException: org.apache.hadoop.hive.ql.metadata.HiveException: Unable to fetch table testpartitiondata. Invalid method name: 'get_table_req';
```
Looking at HIVE-15062, the `get_table_req` is to introduce client-side check for capabilities. However in branch-2.3 the check is a no-op since there is no capability yet (it is assigned to null). Therefore, this JIRA proposes to switch back to `get_table` in branch-2.3 to fix the compatibility issue.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2080:
URL: https://github.com/apache/hive/pull/2080#issuecomment-841376548
Thanks @szehon-ho ! tests failure are unrelated (they are known existing flaky tests). Merging to branch-2.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x
Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #2080:
URL: https://github.com/apache/hive/pull/2080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szehon-ho commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #2080:
URL: https://github.com/apache/hive/pull/2080#issuecomment-841128826
It looks good to me, don't have write access to the repo though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2080:
URL: https://github.com/apache/hive/pull/2080#issuecomment-840028939
cc @szehon-ho could you help to review this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2080:
URL: https://github.com/apache/hive/pull/2080#issuecomment-841387554
Ah cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] szehon-ho commented on pull request #2080: HIVE-24608: Switch back to get_table in HMS client for Hive 2.3.x
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on pull request #2080:
URL: https://github.com/apache/hive/pull/2080#issuecomment-841386933
Sounds good, and I got the write access :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org