[GitHub] [pinot] navina commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids

["navina (via GitHub)" <gi...@apache.org>]

navina commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442676787

   @snleee / @mcvsubbu I don't think Linkedin is using any of the underlying metrics from the kafka consumer in the dashboards, which is what gets affected due to this change. And I agree with @snleee that we shouldn't introduce another knob/api for this. 
   
   More to the point, I don't think linkedin should be using those metrics in the current state at least. They are bound to be inaccurate unless there is an external mechanism in linkedin that can ensure that no topic is consumed by more than 1 pinot table. Moreover, all our spis accept clientId in their interfaces and there is no way currently to customize it. 
   
   Anyway, let's wait for @jugomezv to confirm. Tks all for jumping in! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org