You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "yiy27 (Jira)" <ji...@apache.org> on 2022/05/02 05:13:00 UTC

[jira] [Commented] (CASSANDRA-17591) Move TombstoneOverwhelmingException into org.apache.cassandra.exceptions package

    [ https://issues.apache.org/jira/browse/CASSANDRA-17591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530598#comment-17530598 ] 

yiy27 commented on CASSANDRA-17591:
-----------------------------------

[~jlewandowski] Could you help me review this issue? 

> Move TombstoneOverwhelmingException into org.apache.cassandra.exceptions package
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17591
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17591
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: yiy27
>            Priority: Normal
>
> *Issue Description*
>  ** 
> Package _*org.apache.cassandra.db.filter*_ is a promiscuous package, and groups together miscellaneous functionalities that might be useful to different subsystems. I found that class _*TombstoneOverwhelmingException*_ is not used by classes in its package{_}.{_} During the development process, one groups together classes (that often co-change) with similar responsibilities in one package to facilitate maintenance, which prevents a change that causes other packages to be modified.
> Location: The source file can be found at path File src/java/org/apache/cassandra/db/filter/TombstoneOverwhelmingException.java
>  ** 
> *Refactoring suggestions*
>  
> I suggest that class _*TombstoneOverwhelmingException*_ can be moved into the exception package _*org.apache.cassandra.exceptions*_ that placed all classes about implementing possible exceptions.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org