Re: [PR] CASSGO-1 CASSGO-30 Native Protocol 5 Support [cassandra-gocql-driver]

["joao-r-reis (via GitHub)" <gi...@apache.org>]

joao-r-reis commented on PR #1822:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1822#issuecomment-2460022822

   Hmm it does look weird to have `gocql`'s `go.mod` list `gocql/lz4` as a dependency when `gocql/lz4`'s `go.mod` lists `gocql` as a dependency... A possible solution is to make `lz4` a package instead of its own module, I brought this up in slack and [here](https://github.com/apache/cassandra-gocql-driver/pull/1770#issuecomment-2451102573).
   
   If `lz4` stays a separate module then I'm not sure what is the best way to use `lz4` in the integration tests... Maybe your approach is the best one, if I'm not mistaken the `lz4` dependency will not actually be downloaded by users since it's only used in tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org