You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/04 10:47:16 UTC
[GitHub] [spark] tanelk opened a new pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take in account EqualNullSafe
tanelk opened a new pull request #29650:
URL: https://github.com/apache/spark/pull/29650
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
`InferFiltersFromConstraints` only infers new filters using `EqualTo`, generalized it to also include `EqualNullSafe`.
This introduced an infinite loop on `InferFiltersFromConstraintsSuite`. It has been fixed in the `Optimizer` by restructuring the batches (#19149), did the same in the test suite.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Possible performance improvement
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748460588
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37659/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29650: [WIP][SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29650:
URL: https://github.com/apache/spark/pull/29650#discussion_r483877757
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -882,7 +882,7 @@ object InferFiltersFromConstraints extends Rule[LogicalPlan]
}
}
- private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transform {
+ private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
This might have been a wrong fix.
I now tried adding `right.constraints` to `LeftSemi` joins `validConstraints`. This also fixes that SQLQueryTestSuite failure. `LeftSemi` join is quite like `Inner` join, so it makes sense to have the same constraints, but I'm not 100% sure how having constraints referencing missing columns affects everything. The `InferFiltersFromConstraints.inferNewFilter` will remove those in the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-687071893
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-761051239
**[Test build #134102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134102/testReport)** for PR 29650 at commit [`6d56655`](https://github.com/apache/spark/commit/6d56655d053c675fe906f6a8fc0452daa31f0f47).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748469440
@cloud-fan, it seems you worked on this
also cc @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-691180687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748454463
**[Test build #133059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133059/testReport)** for PR 29650 at commit [`6d56655`](https://github.com/apache/spark/commit/6d56655d053c675fe906f6a8fc0452daa31f0f47).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-760899425
**[Test build #134102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134102/testReport)** for PR 29650 at commit [`6d56655`](https://github.com/apache/spark/commit/6d56655d053c675fe906f6a8fc0452daa31f0f47).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748460581
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37659/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-691180687
Pinging @dongjoon-hyun and @dbtsai , you have also reviewed optimizer changes lately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-691180687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-761052341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134102/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-687279997
@cloud-fan, it seems you worked on this
also cc @maropu, @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29650:
URL: https://github.com/apache/spark/pull/29650#discussion_r483924187
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -882,7 +882,7 @@ object InferFiltersFromConstraints extends Rule[LogicalPlan]
}
}
- private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transform {
+ private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
I believe that the UT "Infer from right side of left semi join" now covers this
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -882,7 +882,7 @@ object InferFiltersFromConstraints extends Rule[LogicalPlan]
}
}
- private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transform {
+ private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
This might have been a wrong fix.
I now tried adding `right.constraints` to `LeftSemi` joins `validConstraints`. This also fixes that SQLQueryTestSuite failure. `LeftSemi` join is quite like `Inner` join, so it makes sense to have the same constraints, but I'm not 100% sure how having constraints referencing missing columns affects everything. The `InferFiltersFromConstraints.inferNewFilter` will remove those in the end.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -882,7 +882,7 @@ object InferFiltersFromConstraints extends Rule[LogicalPlan]
}
}
- private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transform {
+ private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
This fixed the SQLQueryTestSuite failure: https://github.com/apache/spark/pull/29650/checks?check_run_id=1071934445
It is a very complex query, I'm still figuring out how to cover it in a simplified unit test in `InferFiltersFromConstraintsSuite`.
Other failures are covered by the "Infer all constraints from a chain of filters" UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-688406900
> Are you sure we can infer from `EqualNullSafe`? Some `EqualNullSafe` from `Alias`:
I do not follow, why should this make `EqualNullSafe` not work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-760899425
**[Test build #134102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134102/testReport)** for PR 29650 at commit [`6d56655`](https://github.com/apache/spark/commit/6d56655d053c675fe906f6a8fc0452daa31f0f47).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29650: [WIP][SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29650:
URL: https://github.com/apache/spark/pull/29650#discussion_r483756190
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -882,7 +882,7 @@ object InferFiltersFromConstraints extends Rule[LogicalPlan]
}
}
- private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transform {
+ private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
This fixed the SQLQueryTestSuite failure: https://github.com/apache/spark/pull/29650/checks?check_run_id=1071934445
It is a very complex query, I'm still figuring out how to cover it in a simplified unit test in `InferFiltersFromConstraintsSuite`.
Other failures are covered by the "Infer all constraints from a chain of filters" UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29650: [WIP][SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-687279997
@cloud-fan, it seems you worked on this
also cc @maropu, @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29650: [WIP][SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29650:
URL: https://github.com/apache/spark/pull/29650#discussion_r483756190
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -882,7 +882,7 @@ object InferFiltersFromConstraints extends Rule[LogicalPlan]
}
}
- private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transform {
+ private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
This fixed the SQLQueryTestSuite failure: https://github.com/apache/spark/pull/29650/checks?check_run_id=1071934445
It is a very complex query, I'm still figuring out how to cover it in a unit test.
Other failures are covered by the "Infer all constraints from a chain of filters" UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-689674825
Perhaps @gengliangwang and @gatorsmile could take a look? It seems like you have also worked on related topics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-691180687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748487533
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133059/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-828046577
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-687071450
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-761052341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134102/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-761769275
cc @maryannxue too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748487533
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133059/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-687071893
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-687071450
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-691180687
Pinging @dongjoon-hyun and @dbtsai , you have also reviewed optimizer changes lately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #29650:
URL: https://github.com/apache/spark/pull/29650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748460588
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37659/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748483904
**[Test build #133059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133059/testReport)** for PR 29650 at commit [`6d56655`](https://github.com/apache/spark/commit/6d56655d053c675fe906f6a8fc0452daa31f0f47).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748454463
**[Test build #133059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133059/testReport)** for PR 29650 at commit [`6d56655`](https://github.com/apache/spark/commit/6d56655d053c675fe906f6a8fc0452daa31f0f47).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29650: [SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29650:
URL: https://github.com/apache/spark/pull/29650#issuecomment-748458737
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37659/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29650: [WIP][SPARK-32801][SQL] Make InferFiltersFromConstraints take into account EqualNullSafe
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #29650:
URL: https://github.com/apache/spark/pull/29650#discussion_r483924187
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -882,7 +882,7 @@ object InferFiltersFromConstraints extends Rule[LogicalPlan]
}
}
- private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transform {
+ private def inferFilters(plan: LogicalPlan): LogicalPlan = plan transformUp {
Review comment:
I believe that the UT "Infer from right side of left semi join" now covers this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org