You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "Aarchy (via GitHub)" <gi...@apache.org> on 2023/11/27 14:05:54 UTC
[PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Aarchy opened a new pull request, #232:
URL: https://github.com/apache/calcite-avatica/pull/232
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu closed pull request #232: [CALCITE-6135] BEARER authentication support
URL: https://github.com/apache/calcite-avatica/pull/232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #232:
URL: https://github.com/apache/calcite-avatica/pull/232#issuecomment-2597628170
This needs heavy refactoring, now that we have updated httpclient to one which has native BEARER support.
(Copied code needs to be removed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #232:
URL: https://github.com/apache/calcite-avatica/pull/232#issuecomment-1832097896
Can you open a [DISCUSS] thread on the calcite list about this change ?
Explain its background in some detail ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "Aarchy (via GitHub)" <gi...@apache.org>.
Aarchy commented on code in PR #232:
URL: https://github.com/apache/calcite-avatica/pull/232#discussion_r1409199417
##########
core/src/main/java/org/apache/calcite/avatica/remote/SingleBearerTokenProvider.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.avatica.remote;
+
+import org.apache.calcite.avatica.BuiltInConnectionProperty;
+import org.apache.calcite.avatica.ConnectionConfig;
+
+import java.io.IOException;
+
+public class SingleBearerTokenProvider implements BearerTokenProvider {
Review Comment:
This object can provide a single token for its entire lifetime. Maybe Constant?
I'd avoid "Simple" as it may sound that the token is simple in some way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #232:
URL: https://github.com/apache/calcite-avatica/pull/232#discussion_r1409215110
##########
core/src/main/java/org/apache/calcite/avatica/remote/SingleBearerTokenProvider.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.avatica.remote;
+
+import org.apache.calcite.avatica.BuiltInConnectionProperty;
+import org.apache.calcite.avatica.ConnectionConfig;
+
+import java.io.IOException;
+
+public class SingleBearerTokenProvider implements BearerTokenProvider {
Review Comment:
Constant is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #232:
URL: https://github.com/apache/calcite-avatica/pull/232#issuecomment-3886201497
Closing in favor of #299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "Aarchy (via GitHub)" <gi...@apache.org>.
Aarchy commented on PR #232:
URL: https://github.com/apache/calcite-avatica/pull/232#issuecomment-1907809084
@stoty Based on your suggestion on the devlist, token providers now can be plugged in via config properties. Users can define their custom properties and use it in token provider's init function. There's a very basic example in the tests.
On the other hand, the current way of handling properties is a bit confusing in my opinion. For now, I tried to just modify the necessary parts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #232:
URL: https://github.com/apache/calcite-avatica/pull/232#discussion_r1409181587
##########
core/src/main/java/org/apache/calcite/avatica/remote/SingleBearerTokenProvider.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.avatica.remote;
+
+import org.apache.calcite.avatica.BuiltInConnectionProperty;
+import org.apache.calcite.avatica.ConnectionConfig;
+
+import java.io.IOException;
+
+public class SingleBearerTokenProvider implements BearerTokenProvider {
Review Comment:
That name sounds off. Every provider provides a single token (at a time).
Wouldn't SimpleBearerTokenProvider be more descriptive ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6135] BEARER authentication support [calcite-avatica]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #232:
URL: https://github.com/apache/calcite-avatica/pull/232#issuecomment-2440799816
For the record:
This PR copies some of the Bear auth code from httpclient.
What we should do instead do is upgrading to a httpclient with native bearer auth support.
Either to 5.5, which is hopefully going to a have a new SPNEGO implementation, or to 5.4, and re-enable the deprecated SPENGO authentication in it..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org