You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/09 11:13:14 UTC
[GitHub] [spark] zheniantoushipashi opened a new pull request #32109: [SPARK-35007][SQL] support numeric type
zheniantoushipashi opened a new pull request #32109:
URL: https://github.com/apache/spark/pull/32109
What changes were proposed in this pull request?
Spark's numeric is a synonym of decimal
this pr add support for numeric type
Why are the changes needed?
my code need needs to use NUMERIC type in spark2.4 version but not support now
How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zheniantoushipashi commented on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
zheniantoushipashi commented on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-817081128
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-816611876
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zheniantoushipashi commented on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
zheniantoushipashi commented on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-816678252
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zheniantoushipashi commented on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
zheniantoushipashi commented on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-817082356
> Please make pr against master branch:
> 
Hello, my pr is developed based on branch 2.4, why should I submit it to the master branch? The master branch already supports numeric, I want to double commit to the 2.4 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zheniantoushipashi commented on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
zheniantoushipashi commented on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-817111500
> Then, please use Spark 3.x. In general, `branch-2.4` only accepts bug fixes. Please see Versioning Policy: http://spark.apache.org/versioning-policy.html
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-816757492
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-817080840
Please make pr against master branch:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #32109:
URL: https://github.com/apache/spark/pull/32109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-816611876
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-817107491
Then, please use Spark 3.x. In general, `branch-2.4` only accepts bug fixes. Please see Versioning Policy: http://spark.apache.org/versioning-policy.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zheniantoushipashi removed a comment on pull request #32109: [SPARK-35007][SQL] support numeric type
Posted by GitBox <gi...@apache.org>.
zheniantoushipashi removed a comment on pull request #32109:
URL: https://github.com/apache/spark/pull/32109#issuecomment-817081128
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org