You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/21 11:25:36 UTC

[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9147: [Feature] [Lateral-View] support outer combinator of table function

cambyzju commented on code in PR #9147:
URL: https://github.com/apache/incubator-doris/pull/9147#discussion_r855082368


##########
be/src/exprs/table_function/table_function.h:
##########
@@ -99,6 +99,14 @@ class TableFunction {
     }
 
     bool is_outer() const { return _is_outer; }
+    void set_outer() {
+        if (is_outer()) {
+            return;
+        }
+        _is_outer = true;
+        _fn_name += "_outer";

Review Comment:
   use suffix_outer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org