You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "renatsaf (via GitHub)" <gi...@apache.org> on 2026/06/16 21:38:10 UTC
[PR] Add Java SE 26 platform to GlassFish 7.1 and 8.0 server configs [netbeans]
renatsaf opened a new pull request, #9445:
URL: https://github.com/apache/netbeans/pull/9445
Fixes #9423
### Problem
On NetBeans 30 (which bundles JDK 26), starting a GlassFish server pops up the
"select a Java SE platform" dialog with an **empty platform dropdown** and only a
Cancel button, so the server cannot be launched. Reported on Ubuntu against
GlassFish/Payara/WildFly.
### Root cause
Support for JDK 26 was added in `JavaSEPlatform.java` (commit a0d24844f) by adding
the `v26` enum constant, but the corresponding `<platform version="26"/>` entry was
**never added to any GlassFish server config XML**. (The earlier "add JDK 24" change,
1e42bf815, correctly updated both the enum *and* `GlassFishV8_0_0.xml`; the JDK 25 and
JDK 26 changes updated only the enum.)
As a result, `JavaUtils.findSupportedPlatforms(instance)` intersects the installed
platforms with the server's supported set (`{21..25}`) and returns an empty array when
the only registered JDK is 26. `JavaSEPlatformPanel.setDescriptorButtons` then disables
the OK button and `JavaPlatformsComboBox` renders empty — the dialog the user sees.
### Fix
Add `<platform version="26"/>` to the two current-generation GlassFish configs that
already declare JDK 25 support:
- `GlassFishV8_0_0.xml`
- `GlassFishV7_1_0.xml`
This mirrors the established pattern and restores parity between the enum and the config
tables.
### Notes / out of scope
- Older `GlassFishV7_0_*` configs cap at lower JDK levels and represent specific past
releases; adding 26 there is a compatibility judgement and is intentionally left out.
- The Payara configs are considerably more stale (e.g. `PayaraV7.xml` lists only
`<platform version="21"/>`); that looks like a separate, larger gap and is not touched
here.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add Java SE 26 and 27 platforms to GlassFish 7.1 and 8.0 server configs [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9445:
URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4758108592
> Before merging please test the functionality of GF 7.1.0 and 8.0.0 with Java 26/27.
@pepness you are right. I naively assumed that this was tested before the PR was created. 8.0.3 does only start on JDK 25 and below.
(in past, glassfish could be often used to experiment with newer JDKs even though it wasn't officially supported yet)
<details>
classic asm update issue:
```
ERROR: Bundle org.objectweb.asm [13] Error starting file:/home/mbien/dev/servers/glassfish803/glassfish/modules/asm.jar (org.osgi.framework.BundleException: Unable to resolve org.objectweb.asm [13](R 13.0): missing requirement [org.objectweb.asm [13](R 13.0)] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5.0)) Unresolved requirements: [[org.objectweb.asm [13](R 13.0)] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5.0))])
org.osgi.framework.BundleException: Unable to resolve org.objectweb.asm [13](R 13.0): missing requirement [org.objectweb.asm [13](R 13.0)] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5.0)) Unresolved requirements: [[org.objectweb.asm [13](R 13.0)] osgi.ee; (&(osgi.ee=JavaSE)(version=1.5.0))]
at OSGi//org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4398)
at OSGi//org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
at OSGi//org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1566)
at OSGi//org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:297)
at java.base/java.lang.Thread.run(Thread.java:1516)
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add Java SE 26 and 27 platforms to GlassFish 7.1 and 8.0 server configs [netbeans]
Posted by "renatsaf (via GitHub)" <gi...@apache.org>.
renatsaf commented on PR #9445:
URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4728360585
Done — added `version="27"` to both configs and squashed to a single commit (force-pushed).
One note while doing it: a `<platform version="N"/>` entry is actually inert without a matching `JavaSEPlatform` enum constant — `JavaSESet.platforms()` drops unknown version strings via `toValue` (returns `null`), and the installed JDK's spec version is itself resolved through `JavaSEPlatform.toValue` in `JavaUtils.findSupportedPlatforms`. So adding `version="27"` to the XML alone wouldn't have done anything. I added the `v27` enum constant alongside the config entries so 27 is genuinely recognized — and so the enum and config stay in sync, since that asymmetry is exactly what caused this bug. Left the older `GlassFishV7_0_*` configs untouched as you indicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix empty Java SE platform dialog when no compatible JDK is installed [netbeans]
Posted by "renatsaf (via GitHub)" <gi...@apache.org>.
renatsaf commented on PR #9445:
URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4758507404
You're both right — thanks for actually testing. I'd wrongly assumed the empty dropdown was purely a config/enum sync gap; I hadn't verified that GlassFish itself boots on JDK 26, and it doesn't (the asm OSGi `osgi.ee=JavaSE;version=1.5.0` resolution failure @mbien pasted). Advertising 26/27 in the NetBeans config would just trade the empty-dropdown bug for a worse "server dies at startup with a cryptic OSGi trace" bug.
So I've dropped the 26/27 additions (and the `v27` enum constant) and force-pushed. To still close #9423, I reworked the PR to fix the dialog itself: when no installed JDK matches the server's supported range, the panel now shows a message naming the supported range and pointing at **Manage Platforms**, instead of an empty combo with only Cancel. That fixes the reported UX without misrepresenting GlassFish's JDK support. Once a GlassFish release genuinely boots on 26, bumping the config is a one-liner.
I did not build NetBeans locally for this change, so a quick check of the dialog wording on your side would be appreciated.
(Also still watching the dev-list thread on LLM-assisted contributions — happy to adjust presentation based on where that lands.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] GlassFish: Show supported range when no compatible JDK is installed [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9445:
URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4970627665
tested this a bit and it works, at some point we would have to consolidate this with the server config window since it has very similar UI. (ideally without duplicating code)
I think we should also consider changing the logic, since glassfish still leaves the experimental support for newer JDKs open ended. It may or may not work and can change from one point release to another.
https://glassfish.org/docs/7.1.1/release-notes.html#required-jdk-versions
https://glassfish.org/docs/8.0.3/release-notes.html#required-jdk-versions
e.g `Eclipse GlassFish Release 8 requires Java 21 minimum and runs on JDK 21 to JDK 25, with experimental support for higher versions.`
IMO we should let the user run it by not checking the upper bound, if it fails it fails. We can't keep up with the releases anyway.
cc @pepness
but lets get this in, @renatsaf thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix empty Java SE platform dialog when no compatible JDK is installed [netbeans]
Posted by "renatsaf (via GitHub)" <gi...@apache.org>.
renatsaf commented on PR #9445:
URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4969615016
Done — changed `could not` → `can not` in both `JavaSEPlatformPanel.warning` and `JavaSEPlatformPanel.noPlatform`, dropped the history paragraph from the commit message, switched the trailer to `Assisted-by`, and rebased on master + force-pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix empty Java SE platform dialog when no compatible JDK is installed [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #9445:
URL: https://github.com/apache/netbeans/pull/9445#discussion_r3571182005
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ui/Bundle.properties:
##########
@@ -106,6 +106,9 @@ GlassFish 3.0 or later and that server is registered properly in NetBeans.<html>
JavaSEPlatformPanel.title=Java SE Platform
JavaSEPlatformPanel.warning=<html>GlassFish server could not be started with \
<i>{0}</i>. Please select another Java SE Platform.</html>
+JavaSEPlatformPanel.noPlatform=<html>GlassFish server could not be started with \
+<i>{0}</i> and no installed Java SE platform is compatible with this server \
+(supported: {1}). Use <b>Manage Platforms</b> to register a compatible JDK.</html>
Review Comment:
@renatsaf since this is on the configuration dialog, I think we could change `could -> can` so that it reads `GlassFish server can not be started with`. (for both `JavaSEPlatformPanel.warning` and `JavaSEPlatformPanel.noPlatform`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add Java SE 26 and 27 platforms to GlassFish 7.1 and 8.0 server configs [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #9445:
URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4745193659
I use the recommended range as per the release notes from every GlassFish release e.g.
[GlassFish 7.1.0](https://github.com/eclipse-ee4j/glassfish/releases/tag/7.1.0)
`Supported JDK range changed from 11-21 to 17-25.`
In some cases the the is no range, but this release also indicate:
`Fixed compatibility with Java25 + updates`
Before merging please test the functionality of GF 7.1.0 and 8.0.0 with Java 26/27.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] GlassFish: Show supported range when no compatible JDK is installed [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #9445:
URL: https://github.com/apache/netbeans/pull/9445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists