You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/25 03:33:15 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #35652: [SPARK-38316][SQL][TESTS] Fix SQLViewSuite/TriggerAvailableNowSuite/Unwrap*Suite under ANSI mode

gengliangwang commented on a change in pull request #35652:
URL: https://github.com/apache/spark/pull/35652#discussion_r814450025



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/TriggerAvailableNowSuite.scala
##########
@@ -145,6 +146,12 @@ class TriggerAvailableNowSuite extends FileStreamSourceTest {
 
         val q = startQuery()
 
+        def makeDataFrame(a: Seq[Int]): DataFrame = if (SQLConf.get.ansiEnabled) {
+          a.map(_.toLong).toDF()

Review comment:
       This is for making the expected answer of `Long union String`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org