[GitHub] janpio edited a comment on issue #540: Cordova iOS 5.0.0 can not build without `node_modules` present because of missing `shelljs` for build phase script

[GitBox <gi...@apache.org>]

janpio edited a comment on issue #540: Cordova iOS 5.0.0 can not build without `node_modules` present because of missing `shelljs` for build phase script
URL: https://github.com/apache/cordova-ios/issues/540#issuecomment-468665758
 
 
   The file is here: https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/copy-www-build-step.js
   
   History is here: https://github.com/apache/cordova-ios/blame/master/bin/templates/scripts/cordova/lib/copy-www-build-step.js
   
   Changes to the .js file are pretty limited and small:
   - https://github.com/apache/cordova-ios/commit/a5e2fbaaa4d3e75e6cf10135569e58826dc29d47#diff-ccdb57fa59b3a50a04e890de1b4b04c9 removes logic/code that is not needed any more
   - https://github.com/apache/cordova-ios/commit/83435d56d0e7e71a5bbb744cf93684b7e42997f7#diff-ccdb57fa59b3a50a04e890de1b4b04c9 just reformats the code
   - https://github.com/apache/cordova-ios/commit/973517e64c75f46ba0e5779ce7286179b728ac3f#diff-ccdb57fa59b3a50a04e890de1b4b04c9 adds error handling for the `rsync` call, changes the exit code on failure
   - https://github.com/apache/cordova-ios/commit/0ac7bfddd74cde796913fe36f81d145953a68b27#diff-ccdb57fa59b3a50a04e890de1b4b04c9 properly shellescapes the rsync command (so it works with spaces in paths)
   - https://github.com/apache/cordova-ios/commit/36e2012e623aee06a54a1ec69fdca0240083c9b4#diff-ccdb57fa59b3a50a04e890de1b4b04c9 replaces `glob.sync` with exec of `rsync`
   
   https://github.com/apache/cordova-ios/pull/146 is the original PR that switched the script from bash to node, which resolved this issue: https://issues.apache.org/jira/browse/CB-8197
   
   > Currently platform tooling for ios is based on bash scripts and to improve maintainability of such scripts it would be useful to port them to NodeJS.
   
   This is the last version of the shellscript before it was removed via that PR: https://github.com/apache/cordova-ios/blob/f8a5710cbafebfedc000335152777bc307e8b7ac/bin/templates/scripts/cordova/lib/copy-www-build-step.sh
   
   The PR didn't have the "[lot](https://github.com/apache/cordova-ios/blob/master/bin/templates/project/__TEMP__.xcodeproj/project.pbxproj#L279) of effort that goes into making sure it runs with the right node executable" yet, so this was added in a later PR.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org