You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/03/27 18:05:48 UTC
[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s
xiaoxiang781216 opened a new pull request, #1687:
URL: https://github.com/apache/nuttx-apps/pull/1687
## Summary
Code refactor only
## Impact
Should same as before
## Testing
sim:rpserver and sim:rpproxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #1687:
URL: https://github.com/apache/nuttx-apps/pull/1687#discussion_r1151456308
##########
system/cu/cu_main.c:
##########
@@ -291,15 +288,15 @@ int main(int argc, FAR char *argv[])
/* Initialize global data */
- memset(&g_cu, 0, sizeof(struct cu_globals_s));
+ memset(cu, 0, sizeof(struct cu_globals_s));
Review Comment:
Optional: Let's use the same style here and at line 295. So either
```suggestion
memset(cu, 0, sizeof(*cu));
```
Or change line 295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1687:
URL: https://github.com/apache/nuttx-apps/pull/1687#discussion_r1151669606
##########
system/cu/cu_main.c:
##########
@@ -291,15 +288,15 @@ int main(int argc, FAR char *argv[])
/* Initialize global data */
- memset(&g_cu, 0, sizeof(struct cu_globals_s));
+ memset(cu, 0, sizeof(struct cu_globals_s));
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko merged pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #1687:
URL: https://github.com/apache/nuttx-apps/pull/1687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #1687:
URL: https://github.com/apache/nuttx-apps/pull/1687#issuecomment-1488212163
@xiaoxiang781216 will you apply suggestion or should we move to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1687: system/cu: Move fd_std_tty, g_tio_std and g_tio_dev to cu_globals_s
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1687:
URL: https://github.com/apache/nuttx-apps/pull/1687#issuecomment-1488270641
> @xiaoxiang781216 will you apply suggestion or should we move to merge?
Yes, I will apply your suggestion. Please wait a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org