You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2023/01/11 10:44:37 UTC
[GitHub] [opennlp] atarora opened a new pull request, #487: OPENNLP-1437 : Change removeChar() in NumberUtil.java with String.replaceAll + Junits
atarora opened a new pull request, #487:
URL: https://github.com/apache/opennlp/pull/487
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] mawiesne commented on pull request #487: OPENNLP-1437 : Change removeChar() in NumberUtil.java with String.replaceAll + Junits
Posted by GitBox <gi...@apache.org>.
mawiesne commented on PR #487:
URL: https://github.com/apache/opennlp/pull/487#issuecomment-1379142208
Thanks @atarora 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] jzonthemtn merged pull request #487: OPENNLP-1437 : Change removeChar() in NumberUtil.java with String.replaceAll + Junits
Posted by GitBox <gi...@apache.org>.
jzonthemtn merged PR #487:
URL: https://github.com/apache/opennlp/pull/487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp] rzo1 commented on a diff in pull request #487: OPENNLP-1437 : Change removeChar() in NumberUtil.java with String.replaceAll + Junits
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #487:
URL: https://github.com/apache/opennlp/pull/487#discussion_r1066914169
##########
opennlp-uima/src/main/java/opennlp/uima/normalizer/NumberUtil.java:
##########
@@ -90,12 +68,8 @@ public static Number parse(String number, String languageCode)
}
Locale locale = new Locale(languageCode);
-
NumberFormat numberFormat = NumberFormat.getInstance(locale);
-
- number = number.trim();
- number = removeChar(number, ' ');
-
+ number = number.replaceAll("\\s", "");
Review Comment:
Possible follow up: https://issues.apache.org/jira/browse/OPENNLP-1441 (created in discussion with @mawiesne to improve performance throughout the code base)
##########
opennlp-uima/src/main/java/opennlp/uima/normalizer/NumberUtil.java:
##########
@@ -90,12 +68,8 @@ public static Number parse(String number, String languageCode)
}
Locale locale = new Locale(languageCode);
-
NumberFormat numberFormat = NumberFormat.getInstance(locale);
-
- number = number.trim();
- number = removeChar(number, ' ');
-
+ number = number.replaceAll("\\s", "");
Review Comment:
Possible follow up: https://issues.apache.org/jira/browse/OPENNLP-1441 (created in discussion with @mawiesne to improve performance throughout the code base). Martin will have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org