You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Paulex Yang (JIRA)" <ji...@apache.org> on 2006/03/20 09:32:05 UTC

[jira] Created: (HARMONY-216) Refactor java.net to base on o.a.h.luni.platform

Refactor java.net to base on o.a.h.luni.platform
------------------------------------------------

         Key: HARMONY-216
         URL: http://issues.apache.org/jira/browse/HARMONY-216
     Project: Harmony
        Type: Improvement
  Components: Classlib  
    Reporter: Paulex Yang


As we have encapsulate all network related native codes to platform package, I suggest to refactor the java.net to based on it, then we can make net and nio channels share the native codes and remove the duplicate ones. I'll attach the patches soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-216) Refactor java.net to base on o.a.h.luni.platform

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-216?page=all ]
     
Tim Ellison resolved HARMONY-216:
---------------------------------

    Resolution: Fixed

Thanks Paulex,

Refactor looks reasonable, I also updated the manifest and patternset to reflect the new package.
Applied to the LUNI module at repo revision 389483.

Please check that the refactoring was applied as you expected.


> Refactor java.net to base on o.a.h.luni.platform
> ------------------------------------------------
>
>          Key: HARMONY-216
>          URL: http://issues.apache.org/jira/browse/HARMONY-216
>      Project: Harmony
>         Type: Improvement
>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Tim Ellison
>  Attachments: net refactor.zip
>
> As we have encapsulate all network related native codes to platform package, I suggest to refactor the java.net to based on it, then we can make net and nio channels share the native codes and remove the duplicate ones. I'll attach the patches soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-216) Refactor java.net to base on o.a.h.luni.platform

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-216?page=all ]

Paulex Yang updated HARMONY-216:
--------------------------------

    Attachment: net refactor.zip

Execuse me but the patch is a little complex, so pls. follow the steps below to make it work well:

1.apply patch java.net.patch to luni(java.net) in eclipse 
2.copy files in fileAddedToJava.net/* to java.net
3.create package org.apache.harmony.luni.net in luni
4.use eclipse to refactor->Move files from java.net to org.apache.harmony.luni.net:
	GenericIPMreq.java
	NetUtil.java
	PlainDatagramSocketImpl.java
	PlainMulticastSocketImpl.java
	PlainServerSocketImpl.java
	PlainSocketImpl.java
	PlainSocketImpl2.java
	SocketImplProvider.java
	SocketInputStream.java
	SocketOutputStream.java
	Socks4Message.java

> Refactor java.net to base on o.a.h.luni.platform
> ------------------------------------------------
>
>          Key: HARMONY-216
>          URL: http://issues.apache.org/jira/browse/HARMONY-216
>      Project: Harmony
>         Type: Improvement
>   Components: Classlib
>     Reporter: Paulex Yang
>  Attachments: net refactor.zip
>
> As we have encapsulate all network related native codes to platform package, I suggest to refactor the java.net to based on it, then we can make net and nio channels share the native codes and remove the duplicate ones. I'll attach the patches soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-216) Refactor java.net to base on o.a.h.luni.platform

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-216?page=all ]

Tim Ellison reassigned HARMONY-216:
-----------------------------------

    Assign To: Tim Ellison

> Refactor java.net to base on o.a.h.luni.platform
> ------------------------------------------------
>
>          Key: HARMONY-216
>          URL: http://issues.apache.org/jira/browse/HARMONY-216
>      Project: Harmony
>         Type: Improvement
>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Tim Ellison
>  Attachments: net refactor.zip
>
> As we have encapsulate all network related native codes to platform package, I suggest to refactor the java.net to based on it, then we can make net and nio channels share the native codes and remove the duplicate ones. I'll attach the patches soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-216) Refactor java.net to base on o.a.h.luni.platform

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-216?page=comments#action_12372352 ] 

Paulex Yang commented on HARMONY-216:
-------------------------------------

looks good, thank you, Tim

> Refactor java.net to base on o.a.h.luni.platform
> ------------------------------------------------
>
>          Key: HARMONY-216
>          URL: http://issues.apache.org/jira/browse/HARMONY-216
>      Project: Harmony
>         Type: Improvement
>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Tim Ellison
>  Attachments: net refactor.zip
>
> As we have encapsulate all network related native codes to platform package, I suggest to refactor the java.net to based on it, then we can make net and nio channels share the native codes and remove the duplicate ones. I'll attach the patches soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-216) Refactor java.net to base on o.a.h.luni.platform

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-216?page=all ]
     
Tim Ellison closed HARMONY-216:
-------------------------------


Verified by Paulex


> Refactor java.net to base on o.a.h.luni.platform
> ------------------------------------------------
>
>          Key: HARMONY-216
>          URL: http://issues.apache.org/jira/browse/HARMONY-216
>      Project: Harmony
>         Type: Improvement
>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Tim Ellison
>  Attachments: net refactor.zip
>
> As we have encapsulate all network related native codes to platform package, I suggest to refactor the java.net to based on it, then we can make net and nio channels share the native codes and remove the duplicate ones. I'll attach the patches soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira