You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/08 21:22:20 UTC
[GitHub] [superset] dependabot[bot] opened a new pull request, #22071: build(deps): bump react-router-dom from 5.1.2 to 6.4.3 in /superset-frontend
dependabot[bot] opened a new pull request, #22071:
URL: https://github.com/apache/superset/pull/22071
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 5.1.2 to 6.4.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/releases">react-router-dom's releases</a>.</em></p>
<blockquote>
<h2>react-router-dom@6.4.0-pre.15</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p>fix: remove internal router singleton (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9227">#9227</a>)</p>
<p>This change removes the internal module-level <code>routerSingleton</code> we create and maintain inside our data routers since it was causing a number of headaches for non-simple use cases:</p>
<ul>
<li>Unit tests are a pain because you need to find a way to reset the singleton in-between tests
<ul>
<li>Use use a <code>_resetModuleScope</code> singleton for our tests</li>
<li>...but this isn't exposed to users who may want to do their own tests around our router</li>
</ul>
</li>
<li>The JSX children <code><Route></code> objects cause non-intuitive behavior based on idiomatic react expectations
<ul>
<li>Conditional runtime <code><Route></code>'s won't get picked up</li>
<li>Adding new <code><Route></code>'s during local dev won't get picked up during HMR</li>
<li>Using external state in your elements doesn't work as one might expect (see <a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9225">#9225</a>)</li>
</ul>
</li>
</ul>
<p>Instead, we are going to lift the singleton out into user-land, so that they create the router singleton and manage it outside the react tree - which is what react 18 is encouraging with <code>useSyncExternalStore</code> anyways! This also means that since users create the router - there's no longer any difference in the rendering aspect for memory/browser/hash routers (which only impacts router/history creation) - so we can get rid of those and trim to a simple <code>RouterProvider</code></p>
<pre lang="jsx"><code>// Before
function App() {
<DataBrowserRouter>
<Route path="/" element={<Layout />}>
<Route index element={<Home />}>
</Route>
<DataBrowserRouter>
}
<p>// After
let router = createBrowserRouter([{
path: "/",
element: <Layout />,
children: [{
index: true,
element: <Home />,
}]
}]);</p>
<p>function App() {
return <RouterProvider router={router} />
}
</code></pre></p>
<p>If folks still prefer the JSX notation, they can leverage <code>createRoutesFromElements</code> (aliased from <code>createRoutesFromChildren</code> since they are not "children" in this usage):</p>
<pre lang="jsx"><code>let routes = createRoutesFromElements(
<Route path="/" element={<Layout />}>
<Route index element={<Home />}>
</Route>
);
</code></pre>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md">react-router-dom's changelog</a>.</em></p>
<blockquote>
<h2>6.4.3</h2>
<h3>Patch Changes</h3>
<ul>
<li>Fix hrefs generated for <code>createHashRouter</code> (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9409">#9409</a>)</li>
<li>fix encoding/matching issues with special chars (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9477">#9477</a>, <a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9496">#9496</a>)</li>
<li>Properly support <code>index</code> routes with a <code>path</code> in <code>useResolvedPath</code> (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9486">#9486</a>)</li>
<li>Respect <code>relative=path</code> prop on <code>NavLink</code> (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9453">#9453</a>)</li>
<li>Fix <code>NavLink</code> behavior for root urls (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9497">#9497</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>@remix-run/router@1.0.3</code></li>
<li><code>react-router@6.4.3</code></li>
</ul>
</li>
</ul>
<h2>6.4.2</h2>
<h3>Patch Changes</h3>
<ul>
<li>Respect <code>basename</code> in <code>useFormAction</code> (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9352">#9352</a>)</li>
<li>Enhance console error messages for invalid usage of data router hooks (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9311">#9311</a>)</li>
<li>If an index route has children, it will result in a runtime error. We have strengthened our <code>RouteObject</code>/<code>RouteProps</code> types to surface the error in TypeScript. (<a href="https://github-redirect.dependabot.com/remix-run/react-router/pull/9366">#9366</a>)</li>
<li>Updated dependencies:
<ul>
<li><code>react-router@6.4.2</code></li>
<li><code>@remix-run/router@1.0.2</code></li>
</ul>
</li>
</ul>
<h2>6.4.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@6.4.1</code></li>
<li><code>@remix-run/router@1.0.1</code></li>
</ul>
</li>
</ul>
<h2>6.4.0</h2>
<p>Whoa this is a big one! <code>6.4.0</code> brings all the data loading and mutation APIs over from Remix. Here's a quick high level overview, but it's recommended you go check out the [docs][rr-docs], especially the [feature overview][rr-feature-overview] and the [tutorial][rr-tutorial].</p>
<p><strong>New APIs</strong></p>
<ul>
<li>Create your router with <code>createMemoryRouter</code>/<code>createBrowserRouter</code>/<code>createHashRouter</code></li>
<li>Render your router with <code><RouterProvider></code></li>
<li>Load data with a Route <code>loader</code> and mutate with a Route <code>action</code></li>
<li>Handle errors with Route <code>errorElement</code></li>
<li>Submit data with the new <code><Form></code> component</li>
<li>Perform in-page data loads and mutations with <code>useFetcher()</code></li>
<li>Defer non-critical data with <code>defer</code> and <code>Await</code></li>
<li>Manage scroll position with <code><ScrollRestoration></code></li>
</ul>
<p><strong>New Features</strong></p>
<ul>
<li>Perform path-relative navigations with <code><Link relative="path"></code> (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9160">#9160</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/remix-run/react-router/commit/54c3e39ee49c8086bbc45f97a6c9920e6747b906"><code>54c3e39</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9536">#9536</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/f83b12db340b8f4dd1b1260cd29dadb39e33c230"><code>f83b12d</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9513">#9513</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/046239f565f3f131b29bbbad96fc6f2a08effe7c"><code>046239f</code></a> fix: revert navlink back to prior approach (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9497">#9497</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/e50b93792ab430f92840e7728f7ad9c82a53df6f"><code>e50b937</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9501">#9501</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/bba73da53d93dcd5d1ce70ceaa42a1aff6421f52"><code>bba73da</code></a> fix: make url-encoding history-aware (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9496">#9496</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/4b4be06b8948e2bd3e120f3afbc8011d47aa52fd"><code>4b4be06</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9490">#9490</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/ea7351ae995ad12499038a9e551c128c35dd3cc3"><code>ea7351a</code></a> fix: properly support index routes with a path in useResolvedPath (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9486">#9486</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/80d58440eea6201dc55edcb21c8561799b56ee5b"><code>80d5844</code></a> fix: fix encoding/matching issues with special chars (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9477">#9477</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/35ff0250bfa8e3a7d88a6a3bfc5da088bc98b51e"><code>35ff025</code></a> fix: respect relative prop in NavLink for isActive (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9453">#9453</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/9cf02f36f84a3b53e928dc500eb33a889172b03a"><code>9cf02f3</code></a> fix: add router UMD build for unpkg (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/9446">#9446</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/remix-run/react-router/commits/react-router-dom@6.4.3/packages/react-router-dom">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dependabot[bot] commented on pull request #22071: build(deps): bump react-router-dom from 5.1.2 to 6.4.3 in /superset-frontend
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on PR #22071:
URL: https://github.com/apache/superset/pull/22071#issuecomment-1367123763
Superseded by #22546.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dependabot[bot] closed pull request #22071: build(deps): bump react-router-dom from 5.1.2 to 6.4.3 in /superset-frontend
Posted by GitBox <gi...@apache.org>.
dependabot[bot] closed pull request #22071: build(deps): bump react-router-dom from 5.1.2 to 6.4.3 in /superset-frontend
URL: https://github.com/apache/superset/pull/22071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org