You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Randall Meyer <ra...@yahoo.com.INVALID> on 2019/02/14 20:16:36 UTC
github draft PRs
This looks like something good to explore using.
https://github.blog/2019-02-14-introducing-draft-pull-requests/
Re: github draft PRs
Posted by Alan Carroll <so...@verizonmedia.com.INVALID>.
"Change the status to “Ready for review” near the bottom of your pull
request to remove the draft state and allow merging according to your
project’s settings. "
On Fri, Feb 15, 2019 at 3:58 PM Alan Carroll <
solidwallofcode@verizonmedia.com> wrote:
> The github documentation claimed you could remove the "draft" property
> from a draft PR.
>
> On Fri, Feb 15, 2019 at 3:43 PM Walt Karas <wk...@verizonmedia.com.invalid>
> wrote:
>
>> We could also create PRs in our forked repos instead of making a draft PR
>> in the main shared repo.
>>
>> On Fri, Feb 15, 2019 at 3:37 PM Bryan Call <bc...@apache.org> wrote:
>>
>> > I agree, if someone has code that is in a work in progress state then
>> > please use this feature. It would be nice if you could after the fact
>> > change a PR to a draft PR, but I don’t see an option to do that.
>> >
>> > -Bryan
>> >
>> >
>> >
>> > > On Feb 14, 2019, at 12:16 PM, Randall Meyer <randallmeyer@yahoo.com
>> .INVALID>
>> > wrote:
>> > >
>> > > This looks like something good to explore using.
>> > > https://github.blog/2019-02-14-introducing-draft-pull-requests/
>> >
>> >
>>
>
Re: github draft PRs
Posted by Alan Carroll <so...@verizonmedia.com.INVALID>.
The github documentation claimed you could remove the "draft" property from
a draft PR.
On Fri, Feb 15, 2019 at 3:43 PM Walt Karas <wk...@verizonmedia.com.invalid>
wrote:
> We could also create PRs in our forked repos instead of making a draft PR
> in the main shared repo.
>
> On Fri, Feb 15, 2019 at 3:37 PM Bryan Call <bc...@apache.org> wrote:
>
> > I agree, if someone has code that is in a work in progress state then
> > please use this feature. It would be nice if you could after the fact
> > change a PR to a draft PR, but I don’t see an option to do that.
> >
> > -Bryan
> >
> >
> >
> > > On Feb 14, 2019, at 12:16 PM, Randall Meyer <randallmeyer@yahoo.com
> .INVALID>
> > wrote:
> > >
> > > This looks like something good to explore using.
> > > https://github.blog/2019-02-14-introducing-draft-pull-requests/
> >
> >
>
Re: github draft PRs
Posted by Leif Hedstrom <zw...@apache.org>.
> On Feb 15, 2019, at 4:16 PM, Chris Lemmons <al...@gmail.com> wrote:
>
> Generally, I want CI builds for my draft PR. If I break the build, I
> want to know ideally before I ask folks to review it in earnest. As
> long as I'm not pushing so frequently that I tie up the CI, it should
> be ok, right?
>
We would turn it back on again when you turn it into a real PR. The point being that you probably want to push frequently to these draft PRs, as in, I’m doing a big change, and I want to do a lot of small, incremental commits.
—leif
> On Fri, Feb 15, 2019 at 3:39 PM Leif Hedstrom <zw...@apache.org> wrote:
>>
>>
>>
>>> On Feb 15, 2019, at 2:43 PM, Walt Karas <wk...@verizonmedia.com.INVALID> wrote:
>>>
>>> We could also create PRs in our forked repos instead of making a draft PR
>>> in the main shared repo.
>>
>> That kinda defeats the purpose IMO. 1) You want to be able to easily collaborate (having me chase down 40+ other repos, is futile) 2) More importantly, we lose the discussion thread if/ when you turn it into a real PR. As amc points out, this is an important feature of the draft PRs, they can be turned into real PRs once the “WIP” is over with.
>>
>> I haven’t managed to figure out how to turn off automatic builds for the Draft PRs. However, there is a feature in jenkins, if you add a comment like his, it *should* turn off automatic builds:
>>
>> [skip ci]
>>
>>
>> I have not tested this, and presumably, you’d want to add this as the first comment before you actually submit the PR (otherwise, it’ll kick off immediately).
>>
>> — leif
>>
>>>
>>> On Fri, Feb 15, 2019 at 3:37 PM Bryan Call <bc...@apache.org> wrote:
>>>
>>>> I agree, if someone has code that is in a work in progress state then
>>>> please use this feature. It would be nice if you could after the fact
>>>> change a PR to a draft PR, but I don’t see an option to do that.
>>>>
>>>> -Bryan
>>>>
>>>>
>>>>
>>>>> On Feb 14, 2019, at 12:16 PM, Randall Meyer <ra...@yahoo.com.INVALID>
>>>> wrote:
>>>>>
>>>>> This looks like something good to explore using.
>>>>> https://github.blog/2019-02-14-introducing-draft-pull-requests/
>>>>
>>>>
>>
Re: github draft PRs
Posted by Chris Lemmons <al...@gmail.com>.
Generally, I want CI builds for my draft PR. If I break the build, I
want to know ideally before I ask folks to review it in earnest. As
long as I'm not pushing so frequently that I tie up the CI, it should
be ok, right?
On Fri, Feb 15, 2019 at 3:39 PM Leif Hedstrom <zw...@apache.org> wrote:
>
>
>
> > On Feb 15, 2019, at 2:43 PM, Walt Karas <wk...@verizonmedia.com.INVALID> wrote:
> >
> > We could also create PRs in our forked repos instead of making a draft PR
> > in the main shared repo.
>
> That kinda defeats the purpose IMO. 1) You want to be able to easily collaborate (having me chase down 40+ other repos, is futile) 2) More importantly, we lose the discussion thread if/ when you turn it into a real PR. As amc points out, this is an important feature of the draft PRs, they can be turned into real PRs once the “WIP” is over with.
>
> I haven’t managed to figure out how to turn off automatic builds for the Draft PRs. However, there is a feature in jenkins, if you add a comment like his, it *should* turn off automatic builds:
>
> [skip ci]
>
>
> I have not tested this, and presumably, you’d want to add this as the first comment before you actually submit the PR (otherwise, it’ll kick off immediately).
>
> — leif
>
> >
> > On Fri, Feb 15, 2019 at 3:37 PM Bryan Call <bc...@apache.org> wrote:
> >
> >> I agree, if someone has code that is in a work in progress state then
> >> please use this feature. It would be nice if you could after the fact
> >> change a PR to a draft PR, but I don’t see an option to do that.
> >>
> >> -Bryan
> >>
> >>
> >>
> >>> On Feb 14, 2019, at 12:16 PM, Randall Meyer <ra...@yahoo.com.INVALID>
> >> wrote:
> >>>
> >>> This looks like something good to explore using.
> >>> https://github.blog/2019-02-14-introducing-draft-pull-requests/
> >>
> >>
>
Re: github draft PRs
Posted by Leif Hedstrom <zw...@apache.org>.
> On Feb 15, 2019, at 2:43 PM, Walt Karas <wk...@verizonmedia.com.INVALID> wrote:
>
> We could also create PRs in our forked repos instead of making a draft PR
> in the main shared repo.
That kinda defeats the purpose IMO. 1) You want to be able to easily collaborate (having me chase down 40+ other repos, is futile) 2) More importantly, we lose the discussion thread if/ when you turn it into a real PR. As amc points out, this is an important feature of the draft PRs, they can be turned into real PRs once the “WIP” is over with.
I haven’t managed to figure out how to turn off automatic builds for the Draft PRs. However, there is a feature in jenkins, if you add a comment like his, it *should* turn off automatic builds:
[skip ci]
I have not tested this, and presumably, you’d want to add this as the first comment before you actually submit the PR (otherwise, it’ll kick off immediately).
— leif
>
> On Fri, Feb 15, 2019 at 3:37 PM Bryan Call <bc...@apache.org> wrote:
>
>> I agree, if someone has code that is in a work in progress state then
>> please use this feature. It would be nice if you could after the fact
>> change a PR to a draft PR, but I don’t see an option to do that.
>>
>> -Bryan
>>
>>
>>
>>> On Feb 14, 2019, at 12:16 PM, Randall Meyer <ra...@yahoo.com.INVALID>
>> wrote:
>>>
>>> This looks like something good to explore using.
>>> https://github.blog/2019-02-14-introducing-draft-pull-requests/
>>
>>
Re: github draft PRs
Posted by Walt Karas <wk...@verizonmedia.com.INVALID>.
We could also create PRs in our forked repos instead of making a draft PR
in the main shared repo.
On Fri, Feb 15, 2019 at 3:37 PM Bryan Call <bc...@apache.org> wrote:
> I agree, if someone has code that is in a work in progress state then
> please use this feature. It would be nice if you could after the fact
> change a PR to a draft PR, but I don’t see an option to do that.
>
> -Bryan
>
>
>
> > On Feb 14, 2019, at 12:16 PM, Randall Meyer <ra...@yahoo.com.INVALID>
> wrote:
> >
> > This looks like something good to explore using.
> > https://github.blog/2019-02-14-introducing-draft-pull-requests/
>
>
Re: github draft PRs
Posted by Bryan Call <bc...@apache.org>.
I agree, if someone has code that is in a work in progress state then please use this feature. It would be nice if you could after the fact change a PR to a draft PR, but I don’t see an option to do that.
-Bryan
> On Feb 14, 2019, at 12:16 PM, Randall Meyer <ra...@yahoo.com.INVALID> wrote:
>
> This looks like something good to explore using.
> https://github.blog/2019-02-14-introducing-draft-pull-requests/