You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Peter Royal <pr...@managingpartners.com> on 2001/06/12 19:00:13 UTC
[patch] ComposerGenerator.Compose throws ComponentException
I submitted this before but never got any response so I'm doing it again.
If I am submitting it incorrectly, please let me know.
In Avalon, the Composable interface defines that its compose method throws
a ComponentException. In the implementation of the ComposerGenerator in C2,
that exception is not thrown. The patch below adds the throws clause to
ComposerGenerator, and also fixes its subclasses in the C2 tree.
-pete
--patch below--
Index: src/org/apache/cocoon/components/language/markup/xsp/XSPGenerator.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon2/src/org/apache/cocoon/components/language/markup/xsp/XSPGenerator.java,v
retrieving revision 1.2
diff -r1.2 XSPGenerator.java
10a11
> import org.apache.avalon.framework.component.ComponentException;
40c41
< public void compose(ComponentManager manager) {
---
> public void compose(ComponentManager manager) throws ComponentException {
Index: src/org/apache/cocoon/generation/ComposerGenerator.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon2/src/org/apache/cocoon/generation/ComposerGenerator.java,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 ComposerGenerator.java
10a11
> import org.apache.avalon.framework.component.ComponentException;
11a13
>
30c32
< public void compose(ComponentManager manager) {
---
> public void compose(ComponentManager manager) throws
ComponentException {
Index: src/org/apache/cocoon/generation/FileGenerator.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon2/src/org/apache/cocoon/generation/FileGenerator.java,v
retrieving revision 1.9.2.2
diff -r1.9.2.2 FileGenerator.java
54c54
< public void compose(ComponentManager manager) {
---
> public void compose(ComponentManager manager) throws
ComponentException {
Index: src/org/apache/cocoon/generation/ServerPagesGenerator.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon2/src/org/apache/cocoon/generation/ServerPagesGenerator.java,v
retrieving revision 1.7.2.1
diff -r1.7.2.1 ServerPagesGenerator.java
18a19
> import org.apache.avalon.framework.component.ComponentException;
72c73
< public void compose(ComponentManager manager) {
---
> public void compose(ComponentManager manager) throws ComponentException {
--
peter royal -> proyal@managingpartners.com
managing partners, inc. -> http://www.managingpartners.com
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org
Re: [patch] ComposerGenerator.Compose throws ComponentException
Posted by giacomo <gi...@apache.org>.
On Tue, 12 Jun 2001, Peter Royal wrote:
Patch applied, thanks.
Giacomo
> I submitted this before but never got any response so I'm doing it again.
> If I am submitting it incorrectly, please let me know.
>
> In Avalon, the Composable interface defines that its compose method throws
> a ComponentException. In the implementation of the ComposerGenerator in C2,
> that exception is not thrown. The patch below adds the throws clause to
> ComposerGenerator, and also fixes its subclasses in the C2 tree.
> -pete
>
> --patch below--
>
> Index: src/org/apache/cocoon/components/language/markup/xsp/XSPGenerator.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon2/src/org/apache/cocoon/components/language/markup/xsp/XSPGenerator.java,v
> retrieving revision 1.2
> diff -r1.2 XSPGenerator.java
> 10a11
> > import org.apache.avalon.framework.component.ComponentException;
> 40c41
> < public void compose(ComponentManager manager) {
> ---
> > public void compose(ComponentManager manager) throws ComponentException {
>
> Index: src/org/apache/cocoon/generation/ComposerGenerator.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon2/src/org/apache/cocoon/generation/ComposerGenerator.java,v
> retrieving revision 1.1.1.1
> diff -r1.1.1.1 ComposerGenerator.java
> 10a11
> > import org.apache.avalon.framework.component.ComponentException;
> 11a13
> >
> 30c32
> < public void compose(ComponentManager manager) {
> ---
> > public void compose(ComponentManager manager) throws
> ComponentException {
> Index: src/org/apache/cocoon/generation/FileGenerator.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon2/src/org/apache/cocoon/generation/FileGenerator.java,v
> retrieving revision 1.9.2.2
> diff -r1.9.2.2 FileGenerator.java
> 54c54
> < public void compose(ComponentManager manager) {
> ---
> > public void compose(ComponentManager manager) throws
> ComponentException {
> Index: src/org/apache/cocoon/generation/ServerPagesGenerator.java
> ===================================================================
> RCS file:
> /home/cvspublic/xml-cocoon2/src/org/apache/cocoon/generation/ServerPagesGenerator.java,v
> retrieving revision 1.7.2.1
> diff -r1.7.2.1 ServerPagesGenerator.java
> 18a19
> > import org.apache.avalon.framework.component.ComponentException;
> 72c73
> < public void compose(ComponentManager manager) {
> ---
> > public void compose(ComponentManager manager) throws ComponentException {
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org