You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "guoyunfeng (JIRA)" <ji...@apache.org> on 2011/03/28 10:24:05 UTC

[jira] [Created] (THRIFT-1120) C# Compiler List

C# Compiler List 
-----------------

                 Key: THRIFT-1120
                 URL: https://issues.apache.org/jira/browse/THRIFT-1120
             Project: Thrift
          Issue Type: Bug
          Components: C# - Compiler
    Affects Versions: 0.6
            Reporter: guoyunfeng
         Attachments: C#  ListEnd error.diff

t_csharp_generator.cc 

  scope_down(out);
if (ttype->is_map()) {
    indent(out) << "oprot.WriteMapEnd();" << endl;
  } else if (ttype->is_set()) {
    indent(out) << "oprot.WriteSetEnd();" << endl;
  } else if (ttype->is_list()) {
    indent(out) << "oprot.WriteListEnd();" << endl;
  }

  scope_down(out);



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1120) C# Compiler List

Posted by "guoyunfeng (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

guoyunfeng updated THRIFT-1120:
-------------------------------

    Attachment: C#  ListEnd error.diff

> C# Compiler List 
> -----------------
>
>                 Key: THRIFT-1120
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1120
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.6
>            Reporter: guoyunfeng
>              Labels: patch
>         Attachments: C#  ListEnd error.diff
>
>
> t_csharp_generator.cc 
>   scope_down(out);
> if (ttype->is_map()) {
>     indent(out) << "oprot.WriteMapEnd();" << endl;
>   } else if (ttype->is_set()) {
>     indent(out) << "oprot.WriteSetEnd();" << endl;
>   } else if (ttype->is_list()) {
>     indent(out) << "oprot.WriteListEnd();" << endl;
>   }
>   scope_down(out);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1120) proto.WriteListEnd being called in the wrong place

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-1120:
----------------------------------

    Summary: proto.WriteListEnd being called in the wrong place  (was: C# Compiler List )

> proto.WriteListEnd being called in the wrong place
> --------------------------------------------------
>
>                 Key: THRIFT-1120
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1120
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.6
>            Reporter: guoyunfeng
>              Labels: patch
>         Attachments: C#  ListEnd error.diff
>
>
> t_csharp_generator.cc 
>   scope_down(out);
> if (ttype->is_map()) {
>     indent(out) << "oprot.WriteMapEnd();" << endl;
>   } else if (ttype->is_set()) {
>     indent(out) << "oprot.WriteSetEnd();" << endl;
>   } else if (ttype->is_list()) {
>     indent(out) << "oprot.WriteListEnd();" << endl;
>   }
>   scope_down(out);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1120) proto.WriteListEnd being called in the wrong place

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012109#comment-13012109 ] 

Hudson commented on THRIFT-1120:
--------------------------------

Integrated in Thrift #106 (See [https://hudson.apache.org/hudson/job/Thrift/106/])
    THRIFT-1120. csharp: proto.WriteListEnd being called in the wrong place

Patch: guoyunfeng


> proto.WriteListEnd being called in the wrong place
> --------------------------------------------------
>
>                 Key: THRIFT-1120
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1120
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.6
>            Reporter: guoyunfeng
>            Assignee: guoyunfeng
>              Labels: patch
>             Fix For: 0.7
>
>         Attachments: C#  ListEnd error.diff
>
>
> t_csharp_generator.cc 
>   scope_down(out);
> if (ttype->is_map()) {
>     indent(out) << "oprot.WriteMapEnd();" << endl;
>   } else if (ttype->is_set()) {
>     indent(out) << "oprot.WriteSetEnd();" << endl;
>   } else if (ttype->is_list()) {
>     indent(out) << "oprot.WriteListEnd();" << endl;
>   }
>   scope_down(out);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1120) proto.WriteListEnd being called in the wrong place

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-1120.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7
         Assignee: guoyunfeng

I just committed this to TRUNK. Thanks for the patch!

> proto.WriteListEnd being called in the wrong place
> --------------------------------------------------
>
>                 Key: THRIFT-1120
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1120
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.6
>            Reporter: guoyunfeng
>            Assignee: guoyunfeng
>              Labels: patch
>             Fix For: 0.7
>
>         Attachments: C#  ListEnd error.diff
>
>
> t_csharp_generator.cc 
>   scope_down(out);
> if (ttype->is_map()) {
>     indent(out) << "oprot.WriteMapEnd();" << endl;
>   } else if (ttype->is_set()) {
>     indent(out) << "oprot.WriteSetEnd();" << endl;
>   } else if (ttype->is_list()) {
>     indent(out) << "oprot.WriteListEnd();" << endl;
>   }
>   scope_down(out);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira