[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132235#comment-15132235 ] 

ASF GitHub Bot commented on FLINK-3234:
---------------------------------------

GitHub user chiwanpark opened a pull request:

    https://github.com/apache/flink/pull/1585

    [FLINK-3234] [dataSet] Add KeySelector support to sortPartition operation.

    This PR contains following changes:
    
    * Add `sortPartition` methods which receive a `KeySelector` instance or a Scala lambda function
    * Add `SortPartitionOperator` constructor which takes `Keys.SelectorFunctionKeys`
    * Add `getFlatFields` method to `SortPartitionOperator` class for `Keys.SelectorFunctionKeys`
    * Add some test cases

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chiwanpark/flink FLINK-3234

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1585
    
----
commit 8dc8845449b494f1495965015d96f114551abc31
Author: Chiwan Park <ch...@apache.org>
Date:   2016-02-04T11:46:10Z

    [FLINK-3234] [dataSet] Add KeySelector support to sortPartition operation

----


> SortPartition does not support KeySelectorFunctions
> ---------------------------------------------------
>
>                 Key: FLINK-3234
>                 URL: https://issues.apache.org/jira/browse/FLINK-3234
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0, 0.10.1
>            Reporter: Fabian Hueske
>            Assignee: Chiwan Park
>             Fix For: 1.0.0
>
>
> The following is not supported by the DataSet API:
> {code}
> DataSet<MyObject> data = ...
> DataSet<MyObject> data.sortPartition(
>   new KeySelector<MyObject, Long>() {
>     public Long getKey(MyObject v) {
>       ...
>     }
>   }, 
>   Order.ASCENDING);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)