You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/12 10:31:56 UTC
[GitHub] [skywalking] aderm opened a new pull request #4217: Add pom exclude
licene file dir.
aderm opened a new pull request #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom
exclude license file dir.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=h1) Report
> Merging [#4217](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7e5443e4e4c410b2673c1800bca2b4493b010532?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `18.99%`.
[](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4217 +/- ##
=======================================
Coverage 26.89% 26.89%
=======================================
Files 1162 1162
Lines 25389 25389
Branches 3626 3626
=======================================
Hits 6829 6829
Misses 17955 17955
Partials 605 605
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `13.33% <ø> (ø)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | :arrow_up: |
| [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | :arrow_up: |
| [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...king/oap/server/library/module/ModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL01vZHVsZVByb3ZpZGVyLmphdmE=) | `50% <ø> (ø)` | :arrow_up: |
| [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| ... and [64 more](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=footer). Last update [7e5443e...7c3c73a](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom
exclude license file dir.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=h1) Report
> Merging [#4217](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7e5443e4e4c410b2673c1800bca2b4493b010532?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `17.74%`.
[](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4217 +/- ##
==========================================
- Coverage 26.89% 26.86% -0.03%
==========================================
Files 1162 1162
Lines 25389 25389
Branches 3626 3626
==========================================
- Hits 6829 6822 -7
- Misses 17955 17962 +7
Partials 605 605
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `13.33% <ø> (ø)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `54.83% <ø> (ø)` | :arrow_up: |
| [...lking/oap/server/core/query/TraceQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvVHJhY2VRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...erver/receiver/jvm/provider/JVMModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9KVk1Nb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `53.57% <ø> (ø)` | :arrow_up: |
| [.../provider/parser/SegmentParserListenerManager.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL1NlZ21lbnRQYXJzZXJMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...king/oap/server/library/module/ModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL01vZHVsZVByb3ZpZGVyLmphdmE=) | `50% <ø> (ø)` | :arrow_up: |
| [...iver/register/provider/RegisterModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvUmVnaXN0ZXJNb2R1bGVQcm92aWRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| ... and [64 more](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=footer). Last update [7e5443e...7c3c73a](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom
exclude license file dir.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=h1) Report
> Merging [#4217](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/45f280defa1a7dc7683f41767d480bcac61d583d?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `18.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4217 +/- ##
==========================================
+ Coverage 26.38% 26.42% +0.03%
==========================================
Files 1178 1179 +1
Lines 25693 25805 +112
Branches 3725 3749 +24
==========================================
+ Hits 6780 6819 +39
- Misses 18316 18382 +66
- Partials 597 604 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...ap/server/exporter/provider/grpc/GRPCExporter.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyLmphdmE=) | `77.77% <0%> (-5.76%)` | :arrow_down: |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | |
| [.../storage/plugin/jdbc/h2/dao/H2MetricsQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc1F1ZXJ5REFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...king/oap/server/core/query/MetricQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTWV0cmljUXVlcnlTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...server/core/storage/annotation/ValueColumnIds.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9hbm5vdGF0aW9uL1ZhbHVlQ29sdW1uSWRzLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...alking/oap/query/graphql/resolver/MetricQuery.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldHJpY1F1ZXJ5LmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...alking/oap/server/core/query/entity/IntValues.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvZW50aXR5L0ludFZhbHVlcy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [.../plugin/elasticsearch/query/MetricsQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0cmljc1F1ZXJ5RXNEQU8uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=footer). Last update [45f280d...9714c64](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4217:
Add pom exclude license file dir.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#discussion_r366900866
##########
File path: pom.xml
##########
@@ -450,6 +450,12 @@
<exclude>tools/dependencies/known-oap-backend-dependencies.txt</exclude>
<exclude>apm-checkstyle/CHECKSTYLE_HEAD</exclude>
+ <!-- generated file from oap or webapp logs files -->
+ <exclude>**/apm-dist/logs/**</exclude>
Review comment:
But it should not start there. That is my point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add
pom exclude license file dir.
Posted by GitBox <gi...@apache.org>.
aderm commented on a change in pull request #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#discussion_r365640282
##########
File path: pom.xml
##########
@@ -450,6 +450,12 @@
<exclude>tools/dependencies/known-oap-backend-dependencies.txt</exclude>
<exclude>apm-checkstyle/CHECKSTYLE_HEAD</exclude>
+ <!-- generated file from oap or webapp logs files -->
+ <exclude>**/apm-dist/logs/**</exclude>
Review comment:
<img width="900" alt="WX20200113-114517@2x" src="https://user-images.githubusercontent.com/2892433/72232137-2cec4800-35fa-11ea-8503-91999a8c7224.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4217: Add pom exclude
license file dir.
Posted by GitBox <gi...@apache.org>.
aderm commented on issue #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-579557183
so i close it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add
pom exclude license file dir.
Posted by GitBox <gi...@apache.org>.
aderm commented on a change in pull request #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#discussion_r365640282
##########
File path: pom.xml
##########
@@ -450,6 +450,12 @@
<exclude>tools/dependencies/known-oap-backend-dependencies.txt</exclude>
<exclude>apm-checkstyle/CHECKSTYLE_HEAD</exclude>
+ <!-- generated file from oap or webapp logs files -->
+ <exclude>**/apm-dist/logs/**</exclude>
Review comment:
<img width="900" alt="WX20200113-114517@2x" src="https://user-images.githubusercontent.com/2892433/72232137-2cec4800-35fa-11ea-8503-91999a8c7224.png">
In some cases, compilation problems can cause error log generation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add
pom exclude licene file dir.
Posted by GitBox <gi...@apache.org>.
aderm commented on a change in pull request #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#discussion_r365584049
##########
File path: pom.xml
##########
@@ -450,6 +450,12 @@
<exclude>tools/dependencies/known-oap-backend-dependencies.txt</exclude>
<exclude>apm-checkstyle/CHECKSTYLE_HEAD</exclude>
+ <!-- generated file from oap or webapp logs files -->
+ <exclude>**/apm-dist/logs/**</exclude>
Review comment:
If there is an error message during operation, it will be recorded here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4217: Add pom exclude licene
file dir.
Posted by GitBox <gi...@apache.org>.
aderm commented on issue #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573408013
> workspace
Indeed yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4217: Add pom exclude
licene file dir.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573407832
I think you run the plugin test in the workspace, then this could trigger rat failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add
pom exclude license file dir.
Posted by GitBox <gi...@apache.org>.
aderm commented on a change in pull request #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#discussion_r372154315
##########
File path: pom.xml
##########
@@ -450,6 +450,12 @@
<exclude>tools/dependencies/known-oap-backend-dependencies.txt</exclude>
<exclude>apm-checkstyle/CHECKSTYLE_HEAD</exclude>
+ <!-- generated file from oap or webapp logs files -->
+ <exclude>**/apm-dist/logs/**</exclude>
Review comment:
I ca n’t find it now. I looked at the time when the log was generated. It ’s been a long time ago. Indeed, from the current point of view, there is no entry to generate a log.
<img width="768" alt="WX20200129-095628@2x" src="https://user-images.githubusercontent.com/2892433/73321394-4db0d080-427d-11ea-89f5-69872a86f6fc.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4217:
Add pom exclude licene file dir.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#discussion_r365589753
##########
File path: pom.xml
##########
@@ -450,6 +450,12 @@
<exclude>tools/dependencies/known-oap-backend-dependencies.txt</exclude>
<exclude>apm-checkstyle/CHECKSTYLE_HEAD</exclude>
+ <!-- generated file from oap or webapp logs files -->
+ <exclude>**/apm-dist/logs/**</exclude>
Review comment:
I am saying why these logs exist. As nothing should be run there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4217: Add pom exclude
license file dir.
Posted by GitBox <gi...@apache.org>.
aderm commented on issue #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-579570338
Ok, let me update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4217: Add pom exclude
licene file dir.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=h1) Report
> Merging [#4217](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/dcb71cdeee7ad14188fcecb3674172e18d0c6158?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4217 +/- ##
==========================================
- Coverage 26.47% 26.38% -0.09%
==========================================
Files 1178 1178
Lines 25693 25693
Branches 3725 3725
==========================================
- Hits 6802 6780 -22
- Misses 18294 18316 +22
Partials 597 597
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `59.01% <0%> (-18.04%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `67.85% <0%> (-17.86%)` | :arrow_down: |
| [...pm/agent/core/profile/ProfileTaskQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1F1ZXJ5U2VydmljZS5qYXZh) | `43.58% <0%> (-5.13%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `28.08% <0%> (-3.38%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `80.88% <0%> (-1.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=footer). Last update [dcb71cd...45f280d](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom
exclude license file dir.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=h1) Report
> Merging [#4217](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e18a7c0a7a92642ba6135e42c6f22bde495758b6?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4217 +/- ##
==========================================
+ Coverage 26.34% 26.43% +0.08%
==========================================
Files 1179 1179
Lines 25805 25805
Branches 3749 3749
==========================================
+ Hits 6799 6822 +23
+ Misses 18402 18380 -22
+ Partials 604 603 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `82.35% <0%> (+1.47%)` | :arrow_up: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (+3.37%)` | :arrow_up: |
| [...pm/agent/core/profile/ProfileTaskQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1F1ZXJ5U2VydmljZS5qYXZh) | `51.28% <0%> (+7.69%)` | :arrow_up: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `85.71% <0%> (+17.85%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `77.04% <0%> (+18.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=footer). Last update [e18a7c0...f70a4cb](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4217:
Add pom exclude licene file dir.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#discussion_r365581246
##########
File path: pom.xml
##########
@@ -450,6 +450,12 @@
<exclude>tools/dependencies/known-oap-backend-dependencies.txt</exclude>
<exclude>apm-checkstyle/CHECKSTYLE_HEAD</exclude>
+ <!-- generated file from oap or webapp logs files -->
+ <exclude>**/apm-dist/logs/**</exclude>
Review comment:
Why are logs here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4217: Add pom exclude
license file dir.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-575991841
Do yoh continue work on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4217: Add pom exclude
license file dir.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-579561820
> so i close it?
My point is `<exclude>**/apm-dist/logs/**</exclude>` shoule be removed. The workspace one makes sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4217: Add pom exclude licene
file dir.
Posted by GitBox <gi...@apache.org>.
aderm commented on issue #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573402336
However, when executing this command `./mvnw install -Pagent -DskipTests`, the following error will occur. Personally, I think that a reasonable situation, the execution of the above command should pass normally.
<img width="1053" alt="WX20200112-184601@2x" src="https://user-images.githubusercontent.com/2892433/72217619-7c376780-356b-11ea-8a14-1f11aeb21e6c.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom
exclude licene file dir.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=h1) Report
> Merging [#4217](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/dcb71cdeee7ad14188fcecb3674172e18d0c6158?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4217 +/- ##
==========================================
- Coverage 26.47% 26.38% -0.09%
==========================================
Files 1178 1178
Lines 25693 25693
Branches 3725 3725
==========================================
- Hits 6802 6780 -22
- Misses 18294 18316 +22
Partials 597 597
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `59.01% <0%> (-18.04%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `67.85% <0%> (-17.86%)` | :arrow_down: |
| [...pm/agent/core/profile/ProfileTaskQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1F1ZXJ5U2VydmljZS5qYXZh) | `43.58% <0%> (-5.13%)` | :arrow_down: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `28.08% <0%> (-3.38%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4217/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `80.88% <0%> (-1.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=footer). Last update [dcb71cd...45f280d](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4217: Add pom exclude
license file dir.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4217: Add pom exclude license file dir.
URL: https://github.com/apache/skywalking/pull/4217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm edited a comment on issue #4217: Add pom exclude
licene file dir.
Posted by GitBox <gi...@apache.org>.
aderm edited a comment on issue #4217: Add pom exclude licene file dir.
URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573408013
Indeed yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services