[GitHub] [lucene] LuXugang commented on a diff in pull request #870: LUCENE-10502: Refactor hnswVectors format

[GitBox <gi...@apache.org>]

LuXugang commented on code in PR #870:
URL: https://github.com/apache/lucene/pull/870#discussion_r867032344


##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene91/Lucene91Codec.java:
##########
@@ -164,7 +161,7 @@ public final PointsFormat pointsFormat() {
   }
 
   @Override
-  public final KnnVectorsFormat knnVectorsFormat() {
+  public KnnVectorsFormat knnVectorsFormat() {

Review Comment:
   Hi @msokolov , similar to any other old codecs in backward-codes which can't be used for writing and we still want to use`Lucene91Codec` in unit tests(see TestLucene91HnswVectorsFormat.java in RP). so we create a new codec named `Lucene91RWCodec` extended from `Lucene91Codec`  and create a new instance of `KnnVectorsFormat` which could do the write things, so we had to this method not final.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org