[GitHub] [flink] xintongsong commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics

[GitBox <gi...@apache.org>]

xintongsong commented on a change in pull request #9760: [FLINK-13982][runtime] Implement memory calculation logics
URL: https://github.com/apache/flink/pull/9760#discussion_r328014034
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java
 ##########
 @@ -115,6 +115,27 @@ public String toString() {
 		return bytes + " bytes";
 	}
 
+	// ------------------------------------------------------------------------
+	//  Calculations
+	// ------------------------------------------------------------------------
+
+	public MemorySize add(MemorySize that) {
+		return new MemorySize(Math.addExact(this.bytes, that.bytes));
+	}
+
+	public MemorySize subtract(MemorySize that) {
+		return new MemorySize(Math.subtractExact(this.bytes, that.bytes));
+	}
+
+	public MemorySize multiply(double multiplier) {
+		checkArgument(multiplier >= 0, "multiplier must be >= 0");
+		double product = this.bytes * multiplier;
 
 Review comment:
   MemorySize is essentially a size in bytes stored in long type. Converting from double type to long type should not be a problem. We might loose at most 1 byte in each multiply operation due to the rounding down error, which should be acceptable..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services