You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/05/05 16:49:44 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #14778: [Draft][TIR] Require buffer declaration (DeclBuffer) before use
Lunderberg opened a new pull request, #14778:
URL: https://github.com/apache/tvm/pull/14778
Part of [RFC#70](https://github.com/apache/tvm-rfcs/blob/main/rfcs/0070-introducing-decl-buffer.md#engineering-plan), requiring buffers to be declared prior to their usage. This is currently a draft PR, to see what errors are found by the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #14778: [TIR] Require buffer declaration (DeclBuffer) before use
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14778:
URL: https://github.com/apache/tvm/pull/14778#issuecomment-1622168535
And starting the second step of the gradual implementation described [here](https://github.com/apache/tvm/pull/14778#issuecomment-1589904330). https://github.com/apache/tvm/pull/15243 is the first test that adds `DeclBuffer` in an existing lowering pass where it didn't exist before. Hopefully, starting from the end of the lowering flow and working backwards will help to reduce the amount of test failures occurring at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #14778: [TIR] Require buffer declaration (DeclBuffer) before use
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14778:
URL: https://github.com/apache/tvm/pull/14778#issuecomment-1550372331
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/4996801890
<details>
```
Traceback (most recent call last):
File "/home/runner/work/tvm/tvm/ci/scripts/jenkins/git_utils.py", line 121, in _request
with request.urlopen(req, data) as response:
File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib/python3.8/urllib/request.py", line 531, in open
response = meth(req, response)
File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
response = self.parent.error(
File "/usr/lib/python3.8/urllib/request.py", line 569, in error
return self._call_chain(*args)
File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
result = func(*args)
File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "ci/scripts/github/github_tvmbot.py", line 594, in comment_failure
raise item
File "ci/scripts/github/github_tvmbot.py", line 706, in run
pr.rerun_github_actions()
File "ci/scripts/github/github_tvmbot.py", line 583, in rerun_github_actions
raise e
File "ci/scripts/github/github_tvmbot.py", line 575, in rerun_github_actions
actions_github.post(f"actions/runs/{workflow_id}/rerun-failed-jobs", data={})
File "/home/runner/work/tvm/tvm/ci/scripts/jenkins/git_utils.py", line 143, in post
return self._request(self.base + url, data, method="POST")
File "/home/runner/work/tvm/tvm/ci/scripts/jenkins/git_utils.py", line 126, in _request
raise RuntimeError(f"Error response: {msg}\n{error_data}")
RuntimeError: Error response: HTTP Error 403: Forbidden
{"message":"This workflow is already running","documentation_url":"https://docs.github.com/rest/reference/actions#re-run-workflow-failed-jobs"}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14778: [Draft][TIR] Require buffer declaration (DeclBuffer) before use
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14778:
URL: https://github.com/apache/tvm/pull/14778#issuecomment-1536519996
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #14778: [Draft][TIR] Require buffer declaration (DeclBuffer) before use
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14778:
URL: https://github.com/apache/tvm/pull/14778#issuecomment-1537064431
Super excited about this feature!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #14778: [TIR] Require buffer declaration (DeclBuffer) before use
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14778:
URL: https://github.com/apache/tvm/pull/14778#issuecomment-1550371969
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #14778: [TIR] Require buffer declaration (DeclBuffer) before use
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14778:
URL: https://github.com/apache/tvm/pull/14778#issuecomment-1589904330
The strategy in breaking up this PR has been to separate the changes into two types: (1) changes that allow a pass to handle `DeclBuffer` in its input, and (2) changes that cause a pass to produce a `DeclBuffer`. So far, the independent PRs have all been of type (1), as those do not change the behavior when `DeclBuffer` is absent. Once the latest batch of PRs have merged in (#15037, #15044, #15045, #15093, #15094, #15096, and #15098), all passes that need to be aware of `DeclBuffer` should be updated.
Once those PRs have been merged into main, the next stage will be to break out the changes of type (2), starting at the end of the lowering flow and working upstream. That way, the `DeclBuffer` node is only introduced to a few additional passes with each PR, hopefully making any failures easier to debug.
Finally, this PR will be left with just the `VerifyWellFormed` changes, and will serve to validate the additional restrictions on the TIR, while not changing any other behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org