You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/04/11 09:15:42 UTC
[jira] Created: (MNG-283) move MavenSettings.java code into Settings via modello
move MavenSettings.java code into Settings via modello
------------------------------------------------------
Key: MNG-283
URL: http://jira.codehaus.org/browse/MNG-283
Project: m2
Type: Bug
Reporter: Brett Porter
Fix For: 2.0-alpha-2
everything in the MavenSettings class could operate on the Settings class itself, except for the default local repository. Move that code to the MavenCli.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-283) move MavenSettings.java code into Settings via modello
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-283?page=all ]
Brett Porter closed MNG-283:
----------------------------
> move MavenSettings.java code into Settings via modello
> ------------------------------------------------------
>
> Key: MNG-283
> URL: http://jira.codehaus.org/browse/MNG-283
> Project: m2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Fix For: 2.0-alpha-2
>
>
> everything in the MavenSettings class could operate on the Settings class itself, except for the default local repository. Move that code to the MavenCli.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-283) move MavenSettings.java code into Settings via modello
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-283?page=comments#action_31884 ]
Brett Porter commented on MNG-283:
----------------------------------
My intention was that the methods with only operate on the model could be added to the .mdo via <codeSegments>, so that anything using that file can get the active profile without needing to use maven-core, or duplicate code.
> move MavenSettings.java code into Settings via modello
> ------------------------------------------------------
>
> Key: MNG-283
> URL: http://jira.codehaus.org/browse/MNG-283
> Project: m2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Fix For: 2.0-alpha-2
>
>
> everything in the MavenSettings class could operate on the Settings class itself, except for the default local repository. Move that code to the MavenCli.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-283) move MavenSettings.java code into Settings via modello
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-283?page=comments#action_31889 ]
John Casey commented on MNG-283:
--------------------------------
alright, that's a fair point. :)
It's a fairly small cut/paste change, so I'll take care of that tonight or tomorrow.
> move MavenSettings.java code into Settings via modello
> ------------------------------------------------------
>
> Key: MNG-283
> URL: http://jira.codehaus.org/browse/MNG-283
> Project: m2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Fix For: 2.0-alpha-2
>
>
> everything in the MavenSettings class could operate on the Settings class itself, except for the default local repository. Move that code to the MavenCli.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-283) move MavenSettings.java code into Settings via modello
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-283?page=comments#action_31880 ]
John Casey commented on MNG-283:
--------------------------------
Unless we want to add a lot of complexity to our code which uses the settings, we need to have some sort of utility methods for retrieving the active profile/proxy/etc. I wrapped the Settings model object in MavenSettings because it looked like a useful pattern to use (it replicates the value-add to be found in MavenProject vs. Model). We can also provide a static utility class instead, if you prefer, but my preference is to keep these two APIs consistent.
> move MavenSettings.java code into Settings via modello
> ------------------------------------------------------
>
> Key: MNG-283
> URL: http://jira.codehaus.org/browse/MNG-283
> Project: m2
> Type: Bug
> Reporter: Brett Porter
> Assignee: John Casey
> Fix For: 2.0-alpha-2
>
>
> everything in the MavenSettings class could operate on the Settings class itself, except for the default local repository. Move that code to the MavenCli.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org