You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/25 18:05:24 UTC
[GitHub] [airflow] potiuk opened a new pull request #21824: Limits GitHub3.py in order to avoid backtracking
potiuk opened a new pull request #21824:
URL: https://github.com/apache/airflow/pull/21824
Github3 version 3.1.2 requires PyJWT>=2.3.0 which clashes with Flask App
Builder where PyJWT is <2.0.0 Actually GitHub3.1.0 already introduced
PyJWT>=2.3.0 but so far `pip` was able to resolve it without getting
into a long backtracking loop and figure out that github3 3.0.0 version
is the right version similarly limiting it to 3.1.2 causes pip not to
enter the backtracking loop. Apparently when there Are 3 versions with
PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and
fails to resolve that github3 3.0.0 is the right version to use.
This limitation could be removed if PyJWT limitation < 2.0.0 is dropped
from FAB or when pip resolution is improved to handle the case, The
issue which describes this PIP behaviour and hopefully allowing to
improve it is tracked in https://github.com/pypa/pip/issues/10924.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #21824: Limits GitHub3.py in order to avoid backtracking
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #21824:
URL: https://github.com/apache/airflow/pull/21824#discussion_r814987311
##########
File path: setup.py
##########
@@ -599,7 +599,16 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'flake8-colors',
'flaky',
'freezegun',
- 'github3.py',
+ # Github3 version 3.1.2 requires PyJWT>=2.3.0 which clashes with Flask App Builder where PyJWT is <2.0.0
+ # Actually GitHub3.1.0 already introduced PyJWT>=2.3.0 but so far `pip` was able to resolve it without
+ # getting into a long backtracking loop and figure out that github3 3.0.0 version is the right version
+ # similarly limiting it to 3.1.2 causes pip not to enter the backtracking loop. Apparently when there
+ # Are 3 versions with PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and fails
+ # to resolve that github3 3.0.0 is the right version to use.
+ # This limitation could be removed if PyJWT limitation < 2.0.0 is dropped from FAB or when
+ # pip resolution is improved to handle the case, The issue which describes this PIP behaviour
Review comment:
```suggestion
# pip resolution is improved to handle the case. The issue which describes this PIP behaviour
```
##########
File path: setup.py
##########
@@ -599,7 +599,16 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'flake8-colors',
'flaky',
'freezegun',
- 'github3.py',
+ # Github3 version 3.1.2 requires PyJWT>=2.3.0 which clashes with Flask App Builder where PyJWT is <2.0.0
+ # Actually GitHub3.1.0 already introduced PyJWT>=2.3.0 but so far `pip` was able to resolve it without
+ # getting into a long backtracking loop and figure out that github3 3.0.0 version is the right version
+ # similarly limiting it to 3.1.2 causes pip not to enter the backtracking loop. Apparently when there
+ # Are 3 versions with PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and fails
Review comment:
```suggestion
# are 3 versions with PyJWT>=2.3.0 (3.1.0, 3.1.1 an 3.1.2) pip enters into backtrack loop and fails
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21824: Limits GitHub3.py in order to avoid backtracking
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21824:
URL: https://github.com/apache/airflow/pull/21824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #21824: Limits GitHub3.py in order to avoid backtracking
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #21824:
URL: https://github.com/apache/airflow/pull/21824#issuecomment-1051338598
thank you @potiuk 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21824: Limits GitHub3.py in order to avoid backtracking
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21824:
URL: https://github.com/apache/airflow/pull/21824#issuecomment-1051080723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21824: Limits GitHub3.py in order to avoid backtracking
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21824:
URL: https://github.com/apache/airflow/pull/21824#issuecomment-1051137193
That was an accidental fail with image 3.9. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org