You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/18 18:36:17 UTC

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2266: WIP: `LogicalPlan::TableScan` now refers to table provider by name

andygrove opened a new pull request, #2266:
URL: https://github.com/apache/arrow-datafusion/pull/2266

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes https://github.com/apache/arrow-datafusion/issues/2247.
   
   **Note that this is an early WIP and not functional yet.**
   
   I am putting up this PR in an early state to get feedback on the general approach.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   The logical plan currently depends on the physical plan, which prevents us from moving the logical plan into its own crate alongside the logical expressions (which is needed in order to support subqueries, and also to better support the use case where DataFusion is being used just for SQL query planning and then using a different execution engine).
   
   The reason that the logical plan depends on the physical plan is that LogicalPlan::TableScan has a reference to a TableProvider which has a scan method that returns ExecutionPlan.
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   `TableScan` struct now has `table_provider_name` instead of a direct reference to a `TableProvider` instance.
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   Yes, this is an API change.
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove closed pull request #2266: WIP: `LogicalPlan::TableScan` now refers to table provider by name

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #2266: WIP: `LogicalPlan::TableScan` now refers to table provider by name
URL: https://github.com/apache/arrow-datafusion/pull/2266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] matthewmturner commented on pull request #2266: WIP: `LogicalPlan::TableScan` now refers to table provider by name

Posted by GitBox <gi...@apache.org>.
matthewmturner commented on PR #2266:
URL: https://github.com/apache/arrow-datafusion/pull/2266#issuecomment-1103274598

   @andygrove would you be able to provide color on the use case for passing `CatalogList` to optimizer rules / resolving tables during optimization?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #2266: WIP: `LogicalPlan::TableScan` now refers to table provider by name

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2266:
URL: https://github.com/apache/arrow-datafusion/pull/2266#issuecomment-1103922633

   This was too ambitious. Replace with simpler solution in https://github.com/apache/arrow-datafusion/pull/2284


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org