You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/24 09:25:02 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #4177: Reduce conflict of sql_parser.cup
yangzhg opened a new pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177
## Proposed changes
Fix the Shift/Reduce conflict in cup file #4176
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Doris's issues](https://github.com/apache/incubator-doris/issues), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related issues ID
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-663794124
@yangzhg @morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under `fe/fe-core/src/main/cup/` directory？ which is friendly for new contributor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen edited a comment on pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
kangkaisen edited a comment on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-663794124
@yangzhg @morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under `fe/fe-core/src/main/cup/` directory？ which is friendly for new contributor.
It is difficult to describe clearly how to write a cup file with simple sentences, but we can attach a link to the cup syntax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen edited a comment on pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
kangkaisen edited a comment on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-663794124
@yangzhg @morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under `fe/fe-core/src/main/cup/` directory？ which is friendly for new contributor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-664157572
> > @yangzhg @morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under `fe/fe-core/src/main/cup/` directory？ which is friendly for new contributor.
>
> @kangkaisen It is difficult to describe clearly how to write a cup file with simple sentences, but we can attach a link to the cup syntax
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-663557077
If we resolve the reduce conflict, I suggest to modify the `expectedConflicts` in `fe/fe-core/pom.xml` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg edited a comment on pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
yangzhg edited a comment on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-664087561
> @yangzhg @morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under `fe/fe-core/src/main/cup/` directory？ which is friendly for new contributor.
@kangkaisen It is difficult to describe clearly how to write a cup file with simple sentences, but we can attach a link to the cup syntax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-664087141
> If we resolve the reduce conflict, I suggest to modify the `expectedConflicts` in `fe/fe-core/pom.xml` too.
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #4177: Reduce conflict of sql_parser.cup
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #4177:
URL: https://github.com/apache/incubator-doris/pull/4177#issuecomment-664087561
> @yangzhg @morningman Hi, The sql_parser.cup file seems has conflict issue frequently. could we put a readme file or some useful link under `fe/fe-core/src/main/cup/` directory？ which is friendly for new contributor.
@kangkaisen It is difficult to describe clearly how to write a cup file with simple sentences, but we can attach a link to the cup syntax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org