[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34184: GH-34154: [Python] Add `is_nan` expression

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #34184:
URL: https://github.com/apache/arrow/pull/34184#discussion_r1122969200


##########
python/pyarrow/array.pxi:
##########
@@ -1253,6 +1253,16 @@ cdef class Array(_PandasConvertible):
         options = _pc().NullOptions(nan_is_null=nan_is_null)
         return _pc().call_function('is_null', [self], options)
 
+    def is_nan(self):
+        """
+        Return BooleanArray indicating the nan values.
+
+        Returns
+        -------
+        array : boolean Array, where null values are None

Review Comment:
   Ah, OK, I didn't get that at first. Now, I don't think that is something we need to mention here in this docstring (that's true for _all_ functions that return arrow data). And it's also only when converting to native Python objects that this happens, the actual result here is a pyarrow.array, and that doesn't use None (so the explanation would be relevant for a method like `Array.to_pylist()`.
   
   The reason you see it in the tests, is because we allow you to use None to specify a null value when constructing an array (but the None gets converted to a proper "null").



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org