You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanju1010 <gi...@git.apache.org> on 2015/09/30 15:22:56 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/902
CLOUDSTACK-8924: Enable dynamic scaling to run test_scale_vm.py test on simulator
Simulator setup uses the config file from following location:
tools/marvin/marvin/config/setup.cfg
Added global setting parameter "enable.dynamic.scale.vm" to above config file, so that dynamic scale vm tests can be run on simulator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanju1010/cloudstack simulator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/902.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #902
----
commit e81bf937da2f21d0b29b7fc16c126f76a0c85aff
Author: sanjeev <sa...@apache.org>
Date: 2015-09-30T13:18:27Z
CLOUDSTACK-8924: Enable dynamic scaling to run test_scale_vm.py test on Simulator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-151213457
@pvr9711 Can you please share the test results or explain what you did to test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-153689139
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic
scaling t...
Posted by Sanjeev N <sa...@apache.org>.
I will update the PR with required changes suggested by @pvr9711.
On Sat, Oct 24, 2015 at 11:36 PM, remibergsma <gi...@git.apache.org> wrote:
> Github user remibergsma commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/902#issuecomment-150838537
>
> @sanju1010 Any update on this?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-150838537
@sanju1010 Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-153688607
Simple configuration change. Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-151068985
@pvr9711 can you please review this PR? I have made changes as per the review comments and rebased it with master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by pvr9711 <gi...@git.apache.org>.
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-151070859
LGTM, I have tested this on a private setup and is working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/902
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by pvr9711 <gi...@git.apache.org>.
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-145200154
@sanju1010 this is not the right file - the following file needs to be updated - https://github.com/apache/cloudstack/blob/94f1ebb60af320166206c213e18b97a177bc145a/setup/dev/basic.cfg
No Go for this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/902#issuecomment-144703298
@sanju1010 ,
Did you execute the tests after the change?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---