You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by David Simmons <da...@smallscript.com> on 2003/09/25 18:25:40 UTC
svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
[11:19] <dave_s> I'm not sure who to tell, but the latest
"svn-0.30.0-setup.exe" for windows is trashing the Environment $path again
(as per 0.14..). If you don't catch it and fix it from a backup of the $path
it might really hose your machine pretty quickly or screw up reboots.
[11:19] <sussman> dave_s: mail the users@ list and say so.
[11:19] <dave_s> The svn-0.29.0-setup.exe release was not doing this.
[11:19] <sussman> exactly one person generates/maintains the setup.exe
[11:19] <sussman> ahhhhh
-- Dave S. [Smallscript Corp]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
S# for the AOS & .NET Platforms
David.Simmons@Smallscript.com
http://www.smallscript.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14. - Correction
Posted by "Jostein Chr. Andersen" <jo...@josander.net>.
On Thursday 02 October 2003 21.02, Jostein Chr. Andersen wrote:
> I will look at this and do as you sugest within tomorrow (GMT+1).
Correction: I will work on it during this weekend and Monday. I delete
the svnpath program and make a native Inno Setup solution (pascal
script) without any helper programs.
Jostein
--
Jostein Chr. Andersen <jo...@josander.net> http://www.josander.net/
Public PGP Key:
Key: http://www.josander.net/pub_keys/jostein_josander.net.asc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
Posted by "Jostein Chr. Andersen" <jo...@josander.net>.
On Thursday 02 October 2003 19.45, kfogel@collab.net wrote:
> Until you dynamically allocate, you should at least prevent writes
> that run off the end. Maybe you can check the length of the input?
>
> [...]
>
> char buf[1024];
>
> if (len(input) > sizeof(buf))
> {
> abort();
> }
>
> [...]
The current buffer size are 4000, wich is the maximum length in the NT
variations (as far as I know). One user that have this problem had a
path on one machine with a lenght of 160 characters...
I will look at this and do as you sugest within tomorrow (GMT+1).
--
Jostein Chr. Andersen <jo...@josander.net> http://www.josander.net/
Public PGP Key:
Key: http://www.josander.net/pub_keys/jostein_josander.net.asc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
Posted by kf...@collab.net.
"Jostein Chr. Andersen" <jo...@josander.net> writes:
> My C knowledge are limited (svnpath is my second C program, the first was
> named hello.exe).
>
> I will allocate it dynamically as soon as I get time to learn more about
> C (I have seen some examples on how to do it, it don't look to
> difficult), believe me, I'm really looking forward to do it. C looks
> like fun.
Until you dynamically allocate, you should at least prevent writes
that run off the end. Maybe you can check the length of the input?
[...]
char buf[1024];
if (len(input) > sizeof(buf))
{
abort();
}
[...]
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
Posted by "Jostein Chr. Andersen" <jo...@josander.net>.
On Wednesday 01 October 2003 20.43, Branko Čibej wrote:
> Jostein Chr. Andersen wrote:
> >Thanks for the tip! :-) The current buffer size in svnpath.exe is
> > 1024 bytes. I will increase it.
>
> Instead, why don't you allocate it dynamically? Then something like
> this won't happen again.
My C knowledge are limited (svnpath is my second C program, the first was
named hello.exe).
I will allocate it dynamically as soon as I get time to learn more about
C (I have seen some examples on how to do it, it don't look to
difficult), believe me, I'm really looking forward to do it. C looks
like fun.
Jostein
--
Jostein Chr. Andersen <jo...@josander.net> http://www.josander.net/
Public PGP Key:
Key: http://www.josander.net/pub_keys/jostein_josander.net.asc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
Posted by Branko Čibej <br...@xbc.nu>.
Jostein Chr. Andersen wrote:
>On Wednesday 01 October 2003 00.04, David Simmons wrote:
>
>
>>My gut feeling is that there was a buffer overflow in the code that
>>updated the registry entry. I.e., the code that updated the path
>>variable did not have a large enough buffer to handle the ~1000 byte
>>path record. As you may know, the registry can hold very long paths,
>>but the DOS shell environment variables appear to be limited to 1023
>>bytes.
>>
>>
>
>Thanks for the tip! :-) The current buffer size in svnpath.exe is 1024
>bytes. I will increase it.
>
>
Instead, why don't you allocate it dynamically? Then something like this
won't happen again.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
Posted by "Jostein Chr. Andersen" <jo...@josander.net>.
On Wednesday 01 October 2003 00.04, David Simmons wrote:
> My gut feeling is that there was a buffer overflow in the code that
> updated the registry entry. I.e., the code that updated the path
> variable did not have a large enough buffer to handle the ~1000 byte
> path record. As you may know, the registry can hold very long paths,
> but the DOS shell environment variables appear to be limited to 1023
> bytes.
Thanks for the tip! :-) The current buffer size in svnpath.exe is 1024
bytes. I will increase it.
Jostein
--
Jostein Chr. Andersen <jo...@josander.net> http://www.josander.net/
Public PGP Key:
Key: http://www.josander.net/pub_keys/jostein_josander.net.asc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
Posted by David Simmons <da...@smallscript.com>.
System is Windows XP ProfessionalBuild 2600 SP1.
The path entry in the registry was truncated to only include the SVN entry.
The previous path entry was just around 1000 bytes in length.
As to what I am using with SVN -- I am using a variety of items [CMD.EXE,
TortoiseSVN, etc].
The "trashing" happened immediately after a fresh install and was verified
by checking the registry entry. I had uninstalled all previous versions of
SVN.
My gut feeling is that there was a buffer overflow in the code that updated
the registry entry. I.e., the code that updated the path variable did not
have a large enough buffer to handle the ~1000 byte path record. As you may
know, the registry can hold very long paths, but the DOS shell environment
variables appear to be limited to 1023 bytes.
-- Dave S. [Smallscript Corp]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
S# for the AOS & .NET Platforms
David.Simmons@Smallscript.com
http://www.smallscript.org
> -----Original Message-----
> From: Jostein Chr. Andersen [mailto:jostein@josander.net]
> Sent: Friday, September 26, 2003 10:58 AM
> To: David Simmons
> Cc: dev@subversion.tigris.org
> Subject: Re: svn-0.30.0-setup.exe trashing the Environment $path as per
> 0.14.
>
> On Thursday 25 September 2003 20:25, David Simmons wrote:
> > [11:19] <dave_s> I'm not sure who to tell, but the latest
> > "svn-0.30.0-setup.exe" for windows is trashing the Environment $path
> > again (as per 0.14..). If you don't catch it and fix it from a backup
> > of the $path it might really hose your machine pretty quickly or screw
> > up reboots.
> > [11:19] <sussman> dave_s: mail the users@ list and say so.
> > [11:19] <dave_s> The svn-0.29.0-setup.exe release was not doing this.
>
> In which way was your Path trashed?
>
> I need some more data:
> * Which Windows version?
> * You say that $path (not %PATH%)are trashed, are you using Cygwin,
> msys or the standard console when using svn?
> * Did you do a fresh install or upgrade?
> * Anything more I can use?
> * Do you have more than one Subversion installed?
>
> This is weired, because the only new thing about svn-0.30.0-setup.exe is
> the Subversion binaries. The helper programs (svnpath) and the IS Pascal
> Script routines have not been changed for a very long time.
>
> Jostein
>
> --
>
> Jostein Chr. Andersen <jo...@josander.net> http://www.josander.net/
>
> Public PGP Key:
> Key: http://www.josander.net/pub_keys/jostein_josander.net.asc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
Posted by "Jostein Chr. Andersen" <jo...@josander.net>.
On Thursday 25 September 2003 20:25, David Simmons wrote:
> [11:19] <dave_s> I'm not sure who to tell, but the latest
> "svn-0.30.0-setup.exe" for windows is trashing the Environment $path
> again (as per 0.14..). If you don't catch it and fix it from a backup
> of the $path it might really hose your machine pretty quickly or screw
> up reboots.
> [11:19] <sussman> dave_s: mail the users@ list and say so.
> [11:19] <dave_s> The svn-0.29.0-setup.exe release was not doing this.
In which way was your Path trashed?
I need some more data:
* Which Windows version?
* You say that $path (not %PATH%)are trashed, are you using Cygwin,
msys or the standard console when using svn?
* Did you do a fresh install or upgrade?
* Anything more I can use?
* Do you have more than one Subversion installed?
This is weired, because the only new thing about svn-0.30.0-setup.exe is
the Subversion binaries. The helper programs (svnpath) and the IS Pascal
Script routines have not been changed for a very long time.
Jostein
--
Jostein Chr. Andersen <jo...@josander.net> http://www.josander.net/
Public PGP Key:
Key: http://www.josander.net/pub_keys/jostein_josander.net.asc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn-0.30.0-setup.exe trashing the Environment $path as per 0.14.
Posted by "Jostein Chr. Andersen" <jo...@josander.net>.
On Thursday 25 September 2003 20:25, David Simmons wrote:
> [11:19] <dave_s> I'm not sure who to tell, but the latest
> "svn-0.30.0-setup.exe" for windows is trashing the Environment $path
> again (as per 0.14..). If you don't catch it and fix it from a backup
> of the $path it might really hose your machine pretty quickly or screw
> up reboots.
> [11:19] <sussman> dave_s: mail the users@ list and say so.
> [11:19] <dave_s> The svn-0.29.0-setup.exe release was not doing this.
In which way was your Path trashed?
I need some more data:
* Which Windows version?
* You say that $path (not %PATH%)are trashed, are you using Cygwin,
msys or the standard console when using svn?
* Did you do a fresh install or upgrade?
* Anything more I can use?
* Do you have more than one Subversion installed?
This is weired, because the only new thing about svn-0.30.0-setup.exe is
the Subversion binaries. The helper programs (svnpath) and the IS Pascal
Script routines have not been changed for a very long time.
Jostein
--
Jostein Chr. Andersen <jo...@josander.net> http://www.josander.net/
Public PGP Key:
Key: http://www.josander.net/pub_keys/jostein_josander.net.asc
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: Windows binaries - what to do with them?
Posted by Jan Hendrik <ja...@bigfoot.com>.
Concerning Re: Windows binaries - what to do w
Branko Äibej wrote on 26 Sep 2003, 9:27, at least in part:
> Jan Hendrik wrote:
> >
> >Can these be just downloaded and unpacked into the existing SVN
> >folder (use folder names of course) and the mod/lib files copied over
> > to Apache as with the installer, too? (A simple batch file could do
> >this.) Or is it not that easy?
> >
> >
> Yes, this can be done. In fact I don't use the installer myself -- I
> actually unpack the ZIP file I make into a directory that's in my
> path.
>
> I'm not saying we shouldn't have an installer, thought.
Of course not, the installer makes it easier for the not so savvy.
And for the first install anyway. Awful for new users to having read
long instruction text - put this here, put that there!
Jan Hendrik
---------------------------------------
Freedom quote:
They that can give up essential liberty
to obtain a little temporary safety
deserve neither liberty nor safety.
-- Benjamin Franklin
---------------------------------------
Mailed with Pegasus Mail 3.12c (32bit).
Never heard of it?
Easy to use, full featured - and freely available.
And *no* automatic virus activation and spreading.
Take a look at http://www.pmail.com
Give it a try - and you'll never miss anything else.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Re: Windows binaries - what to do with them?
Posted by Branko Čibej <br...@xbc.nu>.
Jan Hendrik wrote:
>I take the screw up of .30 setup.exe for a question on Windows
>binaries as such:
>
>Can these be just downloaded and unpacked into the existing SVN
>folder (use folder names of course) and the mod/lib files copied over
>to Apache as with the installer, too? (A simple batch file could do
>this.) Or is it not that easy?
>
>
Yes, this can be done. In fact I don't use the installer myself -- I
actually unpack the ZIP file I make into a directory that's in my path.
I'm not saying we shouldn't have an installer, thought.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Windows binaries - what to do with them?
Posted by Jan Hendrik <ja...@bigfoot.com>.
I take the screw up of .30 setup.exe for a question on Windows
binaries as such:
Can these be just downloaded and unpacked into the existing SVN
folder (use folder names of course) and the mod/lib files copied over
to Apache as with the installer, too? (A simple batch file could do
this.) Or is it not that easy?
Jan Hendrik
---------------------------------------
Freedom quote:
Yet any time you and I question the schemes of the do-gooders,
we're denounced as being opposed to their humanitarian goals.
It seems impossible to legitimately debate their solutions
with the assumption that all of us share the desire to help
the less fortunate. They tell us we're always 'against',
never 'for' anything.
-- Ronald Reagan, October 27, 1964
---------------------------------------
Mailed with Pegasus Mail 3.12c (32bit).
Never heard of it?
Easy to use, full featured - and freely available.
And *no* automatic virus activation and spreading.
Take a look at http://www.pmail.com
Give it a try - and you'll never miss anything else.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org