You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ku...@apache.org on 2017/04/28 08:20:19 UTC
flink git commit: [FLINK-6398] RowSerializer's duplicate should
always return a new instance
Repository: flink
Updated Branches:
refs/heads/master 8ef6926f3 -> b0cd48dd3
[FLINK-6398] RowSerializer's duplicate should always return a new instance
This closes #3794.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/b0cd48dd
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/b0cd48dd
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/b0cd48dd
Branch: refs/heads/master
Commit: b0cd48dd31975aac88b4da32f31b14500b89edae
Parents: 8ef6926
Author: Kurt Young <yk...@gmail.com>
Authored: Thu Apr 27 23:37:21 2017 +0800
Committer: Kurt Young <ku...@apache.org>
Committed: Fri Apr 28 16:19:49 2017 +0800
----------------------------------------------------------------------
.../api/java/typeutils/runtime/RowSerializer.java | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/b0cd48dd/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java b/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
index 827c2fa..dbd5d3a 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowSerializer.java
@@ -53,22 +53,11 @@ public class RowSerializer extends TypeSerializer<Row> {
@Override
public TypeSerializer<Row> duplicate() {
- boolean stateful = false;
TypeSerializer<?>[] duplicateFieldSerializers = new TypeSerializer[fieldSerializers.length];
-
for (int i = 0; i < fieldSerializers.length; i++) {
duplicateFieldSerializers[i] = fieldSerializers[i].duplicate();
- if (duplicateFieldSerializers[i] != fieldSerializers[i]) {
- // at least one of them is stateful
- stateful = true;
- }
- }
-
- if (stateful) {
- return new RowSerializer(duplicateFieldSerializers);
- } else {
- return this;
}
+ return new RowSerializer(duplicateFieldSerializers);
}
@Override