You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/24 09:09:22 UTC
[GitHub] [apisix] haoyang1994 commented on a change in pull request #6160: fix(request-id): if the header_name is already present in the…
haoyang1994 commented on a change in pull request #6160:
URL: https://github.com/apache/apisix/pull/6160#discussion_r813679221
##########
File path: apisix/plugins/request-id.lua
##########
@@ -214,6 +214,8 @@ function _M.rewrite(conf, ctx)
local uuid_val = get_request_id(conf.algorithm)
if not headers[conf.header_name] then
core.request.set_header(ctx, conf.header_name, uuid_val)
+ else
+ uuid_val = headers[conf.header_name]
Review comment:
This change should be submitted with an switch. In my situation, i can't trust the request id I received and must rewrite it with a new uuid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org