[jira] [Commented] (OAK-3878) Avoid caching of NodeDocument while iterating in BlobReferenceIterator

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219735#comment-15219735 ] 

Chetan Mehrotra commented on OAK-3878:
--------------------------------------

[~mreutegg] [~reschke] Coming back on this. Should I just add one more param and adapt the calling code. Other than wrappers its called in 3 places. Or should I wait for a broader change around query method api?

{code}
    <T extends Document> List<T> query(Collection<T> collection,
                                       String fromKey,
                                       String toKey,
                                       String indexedProperty,
                                       long startValue,
                                       int limit,
                                       boolean cacheResults)
);
{code}



> Avoid caching of NodeDocument while iterating in BlobReferenceIterator
> ----------------------------------------------------------------------
>
>                 Key: OAK-3878
>                 URL: https://issues.apache.org/jira/browse/OAK-3878
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.6
>
>
> {{BlobReferenceIterator}} in DocumentMK makes use of {{DocumentStore}} API to query the NodeDocument. This would cause all those NodeDocuments to be added to cache in DocumentStore. Due to this when blob gc is running cache usage would not be that effective due to all the associated churn. 
> As these NodeDocument are only required for BlobGC logic and its not expected that this document would read again soon it would be better to skip caching of these documents within DocumentStore
> Similar requirement exist in VersionGC logic but there we use direct store based API which does not add such documents to the cache



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)