[jira] [Commented] (DISPATCH-409) Generated identity strings have inconsistent format for various types

["Alan Conway (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DISPATCH-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353068#comment-15353068 ] 

Alan Conway commented on DISPATCH-409:
--------------------------------------

A few more details:

All entities still have usable names. The new C entites do not have usable identities. The old entities simply use identity==name, since there does not seem to be any good use for the identity/name distinction. Perhaps the new entities should do the same?

If there is a deliberate reason for changing to type-scoped identities, then the old entities, the python agent code, and the tools, all need to be updated to reflect that change. 

Here's an example of the current problem:

{code}
[aconway@wallace proton (master $=)]$ qdmanage read --name connection/localhost.localdomain:35670:10
{
  "container": "f08542c5-5f54-448d-9c80-57b6396cf049", 
  "opened": true, 
  "ssl": false, 
  "host": "localhost.localdomain:35670", 
  "isEncrypted": false, 
  "role": "normal", 
  "user": "anonymous", 
  "isAuthenticated": true, 
  "identity": 10, 
  "sasl": "ANONYMOUS", 
  "type": "org.apache.qpid.dispatch.connection", 
  "properties": {
    "qpid.client_ppid": 11373, 
    "qpid.client_process": "qpid-receive", 
    "qpid.client_pid": 367
  }, 
  "dir": "in", 
  "name": "connection/localhost.localdomain:35670:10"
}
[aconway@wallace proton (master $=)]$ qdmanage read --identity connection/localhost.localdomain:35670:10
NotFoundStatus: No entity with identity='connection/localhost.localdomain:35670:10'
[aconway@wallace proton (master $=)]$ qdmanage read --identity 10
NotFoundStatus: No entity with identity='10'
[aconway@wallace proton (master $=)]$ qdmanage read --identity connection/10
NotFoundStatus: No entity with identity='connection/10'
[aconway@wallace proton (master $=)]$ qdmanage read --type connection --identity 10
NotFoundStatus: No entity with identity='10'
{code}

> Generated identity strings have inconsistent format for various types
> ---------------------------------------------------------------------
>
>                 Key: DISPATCH-409
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-409
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 0.6.0
>            Reporter: Jiri Danek
>
> When creating {{autoLink}}s, they get assigned identities in the form of a simple number, e.g. "4"
> {noformat}
> $ qdmanage query --type autoLink
> [
>   ...
>   {
>     "addr": "jms.queue.second",
>     "linkRef": "20",
>     "operStatus": "active",
>     "connection": "ba",
>     "identity": "5",
>     "phase": 0,
>     "type": "org.apache.qpid.dispatch.router.config.autoLink",
>     "dir": "out"
>   }
> ]
> {noformat}
> In contrast to that, connectors do get much more sophisticated identity strings, for example {{connector/172.28.128.221:amqp:ba}}.
> I'd expect the identity strings to have a consistent form across types.
> To be consistent with python the autoLink shown above should be {{"identity": "autoLink/5"}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org