You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/04 00:26:06 UTC

[GitHub] [superset] mihir174 commented on pull request #12903: fix(explore): hide time section for datasets with no time column

mihir174 commented on pull request #12903:
URL: https://github.com/apache/superset/pull/12903#issuecomment-772929800


   +1 from me. I think hiding the time section for when there are no temporal columns makes sense. We shouldn't be providing users an option they cannot act on. 
   
   Re: user confusion- it could be just as confusing for a user to notice a missing `time` section as it is for them to open an empty `time column` dropdown 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org