You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cfries <gi...@git.apache.org> on 2017/04/08 20:05:12 UTC
[GitHub] zeppelin pull request #2235: ZEPPELIN-2375: Avoid modification of CLASSPATH ...
GitHub user cfries opened a pull request:
https://github.com/apache/zeppelin/pull/2235
ZEPPELIN-2375: Avoid modification of CLASSPATH variable.
The script previously modified the CLASSPATH variable. This may lead to
an undesired side effect, where the zeppelin server classpath is
exported to the zeppelin interpreter classpath, see JIRA issue
ZEPPELIN-2375 for details. Instead of modifying classpath we now work
the other way around and set ZEPPELIN_CLASSPATH or
ZEPPELIN_INT_CLASSPATH to include CLASSPATH and then use
ZEPPELIN_CLASSPATH or ZEPPELIN_INT_CLASSPATH in the corresponding exec
(runner), respectively.
See also https://issues.apache.org/jira/browse/ZEPPELIN-2375
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cfries/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2235
----
commit 72dbdb40b9b5638e0670182962d3fae987ceaad4
Author: Christian Fries <em...@christian-fries.de>
Date: 2017-04-08T20:00:33Z
ZEPPELIN-2375: Avoid modification of CLASSPATH variable.
The script previously modified the CLASSPATH variable. This may lead to
an undesired side effect, where the zeppelin server classpath is
exported to the zeppelin interpreter classpath, see JIRA issue
ZEPPELIN-2375 for details. Instead of modifying classpath we now work
the other way around and set ZEPPELIN_CLASSPATH or
ZEPPELIN_INT_CLASSPATH to include CLASSPATH and then use
ZEPPELIN_CLASSPATH or ZEPPELIN_INT_CLASSPATH in the corresponding exec
(runner), respectively.
See also https://issues.apache.org/jira/browse/ZEPPELIN-2375
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPAT...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2235
CI build passed.
https://travis-ci.org/cfries/zeppelin/builds/224499519
Merge to master and branch-0.7 if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2235
great, I review again after rereading what you are saying and I think they make sense and starting ZEPPELIN_CLASSPATH with CLASSPATH should make in compatible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by cfries <gi...@git.apache.org>.
Github user cfries commented on the issue:
https://github.com/apache/zeppelin/pull/2235
Also: on OS X the zeppelin does not run if you export CLASSPATH. So I assume no body could rely on this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by cfries <gi...@git.apache.org>.
Github user cfries commented on the issue:
https://github.com/apache/zeppelin/pull/2235
@Leemoonsoo Ups. Sorry for that. Will fix asap...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by cfries <gi...@git.apache.org>.
Github user cfries commented on the issue:
https://github.com/apache/zeppelin/pull/2235
Hi Felix.
I am not sure if I got your point. The user can change CLASSPATH and zeppelin.sh will use that. Also, the user can change ${ZEPPELIN_CLASSPATH_OVERRIDES} and ${ZEPPELIN_INTP_CLASSPATH_OVERRIDES} to add additional files to the class path without changing CLASSPATH. I assume my change is backward compatible. It is just that the script does not change the CLASSPATH variable. But since the script is not supposed to call another script, this should be OK.
In my option the side effect that the zeppelin.sh is polluting CLASSPATH with the value of ZEPPELIN_CLASSPATH, which is then exported to interpreter.sh is a bug, because it does not allow to use a JAR in zeppelin server which should NOT be used in zeppelin interpreter. With my modification this is possible.
Again: w.r.t. backward compatibility: I would assume that no one should rely on the bug and if he relied on it, he can fix it by setting ZEPPELIN_INTP_CLASSPATH_OVERRIDES or ZEPPELIN_INTP_CLASSPATH.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2235
hmm, I can see your approach though I can also see changing CLASS_PATH makes sense in some cases (for example, a custom library to be loaded).
Do you think there is way to accommodate that? also, is there a way this could be configurable to be backward compatible?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2235
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2235
@cfries looks like this PR is now including other changes? Could you rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2235: [ZEPPELIN-2375]: Avoid modification of CLASSPATH varia...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2235
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---