You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/22 08:33:18 UTC
[GitHub] [incubator-yunikorn-k8shim] steinsgateted opened a new pull request #372: [YUNIKORN-1088] remove empty updates from nodes calls
steinsgateted opened a new pull request #372:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/372
### What is this PR for?
remove an empty AllocationRequest (just the RmID)
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-1088
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #372: [YUNIKORN-1088] remove empty updates from nodes calls
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #372:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/372#issuecomment-1047552986
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/372?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#372](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/372?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6962f78) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c912fbe79152192c1d3b8b3df96c666f72a0d162?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c912fbe) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/372?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 64.43% 64.51% +0.07%
==========================================
Files 41 41
Lines 6144 6123 -21
==========================================
- Hits 3959 3950 -9
+ Misses 2032 2023 -9
+ Partials 153 150 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/372?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `91.57% <ø> (+5.14%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/372?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/372?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c912fbe...6962f78](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/372?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] manirajv06 closed pull request #372: [YUNIKORN-1088] remove empty updates from nodes calls
Posted by GitBox <gi...@apache.org>.
manirajv06 closed pull request #372:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] manirajv06 commented on pull request #372: [YUNIKORN-1088] remove empty updates from nodes calls
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #372:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/372#issuecomment-1047923532
+1. looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org