You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/11/26 13:08:38 UTC

[PR] [WIP][SPARK-46101][SQL] Reduce stack depth by replace (string|array).size with (string|array).length [spark]

beliefer opened a new pull request, #44016:
URL: https://github.com/apache/spark/pull/44016

   ### What changes were proposed in this pull request?
   There are a lot of `[string|array].size` called.
   In fact, the size calls the underlying length, this behavior increase the stack length.
   We should call `[string|array].length` directly.
   We also get the compile waring `Replace .size with .length on arrays and strings`
   
   
   ### Why are the changes needed?
   Reduce stack depth by replace (string|array).size with (string|array).length
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   
   
   ### How was this patch tested?
   Exists test cases.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   'No'.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46101][CORE][SQL][MLLIB][SS][R][CONNCT][GRAPHX] Reduce stack depth by replace (string|array).size with (string|array).length [spark]

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #44016:
URL: https://github.com/apache/spark/pull/44016#issuecomment-1830311473

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46101][SQL] Reduce stack depth by replace (string|array).size with (string|array).length [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #44016:
URL: https://github.com/apache/spark/pull/44016#issuecomment-1829199770

   ping @srowen @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46101][CORE][SQL][MLLIB][SS][R][CONNCT][GRAPHX] Reduce stack depth by replace (string|array).size with (string|array).length [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #44016:
URL: https://github.com/apache/spark/pull/44016#issuecomment-1831101286

   @srowen @LuciferYang Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46101][CORE][SQL][MLLIB][SS][R][CONNCT][GRAPHX] Reduce stack depth by replace (string|array).size with (string|array).length [spark]

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #44016: [SPARK-46101][CORE][SQL][MLLIB][SS][R][CONNCT][GRAPHX] Reduce stack depth by replace (string|array).size with (string|array).length
URL: https://github.com/apache/spark/pull/44016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org