You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/30 17:11:42 UTC

[GitHub] [superset] geido commented on a diff in pull request #22273: feat(native-filters): Adjust filter components for horizontal mode

geido commented on code in PR #22273:
URL: https://github.com/apache/superset/pull/22273#discussion_r1036222846


##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -323,11 +325,23 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
           onChange={handleChange}
           ref={inputRef}
           loading={isRefreshing}
-          maxTagCount={5}
+          maxTagCount={
+            filterBarOrientation === FilterBarOrientation.HORIZONTAL
+              ? 'responsive'
+              : 5

Review Comment:
   Can we put this is a constant at the top of the file just to make it more discoverable?



##########
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx:
##########
@@ -31,6 +31,7 @@ import { PluginFilterRangeProps } from './types';
 import { StatusMessage, StyledFormItem, FilterPluginStyle } from '../common';
 import { getRangeExtraFormData } from '../../utils';
 import { SingleValueType } from './SingleValueType';
+import { FilterBarOrientation } from '../../../dashboard/types';

Review Comment:
   Can we use an absolute path here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org