You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Kevin Sutter (JIRA)" <ji...@apache.org> on 2007/02/08 15:06:05 UTC
[jira] Created: (OPENJPA-137) Perform parameter validation for
annotated callback methods
Perform parameter validation for annotated callback methods
-----------------------------------------------------------
Key: OPENJPA-137
URL: https://issues.apache.org/jira/browse/OPENJPA-137
Project: OpenJPA
Issue Type: Sub-task
Components: jpa
Reporter: Kevin Sutter
Priority: Minor
This is a follow-on Issue to OPENJPA-133. Issue 133 was concerned with properly processing the xml configuration of callback methods. As I was experimenting with that scenario, I discovered that our processing for annotated callback methods and xml callback methods is not consistent. While we do parameter validation for the xml-configured callbacks, we do not do any validation of the annotated callback methods. We just assume that the signature is valid. An incorrectly configured annotated callback method is not detected until runtime and then the user will get an IllegalArgumentException. It's good that we eventually catch and log this condition, but if we could do the validation earlier like we do for xml-configured callbacks, the user will know about the problem much earlier in the process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-137) Perform parameter validation for
annotated callback methods
Posted by "Patrick Linskey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Linskey updated OPENJPA-137:
------------------------------------
Fix Version/s: 1.0.0
> Perform parameter validation for annotated callback methods
> -----------------------------------------------------------
>
> Key: OPENJPA-137
> URL: https://issues.apache.org/jira/browse/OPENJPA-137
> Project: OpenJPA
> Issue Type: Sub-task
> Components: jpa
> Reporter: Kevin Sutter
> Priority: Minor
> Fix For: 1.0.0
>
>
> This is a follow-on Issue to OPENJPA-133. Issue 133 was concerned with properly processing the xml configuration of callback methods. As I was experimenting with that scenario, I discovered that our processing for annotated callback methods and xml callback methods is not consistent. While we do parameter validation for the xml-configured callbacks, we do not do any validation of the annotated callback methods. We just assume that the signature is valid. An incorrectly configured annotated callback method is not detected until runtime and then the user will get an IllegalArgumentException. It's good that we eventually catch and log this condition, but if we could do the validation earlier like we do for xml-configured callbacks, the user will know about the problem much earlier in the process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.