[GitHub] [fineract] taskain7 commented on a diff in pull request #3114: [FINERACT-1678] Exclude loan IDs from execution context parameter name fix

["taskain7 (via GitHub)" <gi...@apache.org>]

taskain7 commented on code in PR #3114:
URL: https://github.com/apache/fineract/pull/3114#discussion_r1165075146


##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/ApplyLoanLockTasklet.java:
##########
@@ -65,7 +65,7 @@ public RepeatStatus execute(@NotNull StepContribution contribution, @NotNull Chu
             loanIds = Collections.emptyList();
         } else {
             loanIds = new ArrayList<>(loanRepository.findAllNonClosedLoansBehindOrNullByMinAndMaxLoanId(loanCOBParameter.getMinLoanId(),
-                    loanCOBParameter.getMaxLoanId(), ThreadLocalContextUtil.getBusinessDateByType(BusinessDateType.COB_DATE)));
+                    loanCOBParameter.getMaxLoanId(), ThreadLocalContextUtil.getBusinessDateByType(BusinessDateType.COB_DATE).minusDays(1)));

Review Comment:
   moved the `NUMBER_OF_DAYS_BEHIND` to `LoanCOBConstant` and use it here as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org