[GitHub] [superset] eschutho commented on a change in pull request #17788: fix: accept null params for validation

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #17788:
URL: https://github.com/apache/superset/pull/17788#discussion_r771628674



##########
File path: superset/views/core.py
##########
@@ -2395,7 +2395,7 @@ def validate_sql_json(
         schema = request.form.get("schema") or None
         template_params = json.loads(request.form.get("templateParams") or "{}")
 
-        if len(template_params) > 0:
+        if template_params is not None and len(template_params) > 0:

Review comment:
       thanks! Sorry, I just saw this note after I merged. I can clean it up separately.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org