You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "leo0842 (via GitHub)" <gi...@apache.org> on 2023/06/20 08:38:49 UTC
[GitHub] [kafka] leo0842 opened a new pull request, #13881: fix typo of ProducerConfig and KafkaProducer
leo0842 opened a new pull request, #13881:
URL: https://github.com/apache/kafka/pull/13881
ADPATIVE -> ADAPTIVE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #13881: MINOR: fix typo of ProducerConfig and KafkaProducer
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on code in PR #13881:
URL: https://github.com/apache/kafka/pull/13881#discussion_r1235909656
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -94,8 +94,8 @@ public class ProducerConfig extends AbstractConfig {
+ "batch size is under this <code>batch.size</code> setting.";
/** <code>partitioner.adaptive.partitioning.enable</code> */
- public static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable";
Review Comment:
This is a public field in a public class: https://kafka.apache.org/35/javadoc/org/apache/kafka/clients/producer/ProducerConfig.html#PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG
Many customers may have code which may be relying on this typo and this change will break those customers. There is very little upside in changing it now and huge downside wrt backward compatibility. I will suggest to keep it as it is for now. We will have to live with it until next major version (4.x).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13881: MINOR: fix typo of ProducerConfig and KafkaProducer
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13881:
URL: https://github.com/apache/kafka/pull/13881#issuecomment-1600829354
@leo0842 since this is your first contribution (thank you for your participation!), you may not be familiar with the concept of KIP. You can read more about it here: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13881: MINOR: fix typo of ProducerConfig and KafkaProducer
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13881:
URL: https://github.com/apache/kafka/pull/13881#issuecomment-1726830843
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #13881: MINOR: fix typo of ProducerConfig and KafkaProducer
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on code in PR #13881:
URL: https://github.com/apache/kafka/pull/13881#discussion_r1236994770
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -94,8 +94,8 @@ public class ProducerConfig extends AbstractConfig {
+ "batch size is under this <code>batch.size</code> setting.";
/** <code>partitioner.adaptive.partitioning.enable</code> */
- public static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable";
Review Comment:
Thanks for your suggestion, that is the right way to go about it @C0urante. I understand that a KIP for this change might be a an overdo but let's follow the rules decided by the community (and create a KIP for deprecation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix typo of ProducerConfig and KafkaProducer [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13881:
URL: https://github.com/apache/kafka/pull/13881#issuecomment-2563280328
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: fix typo of ProducerConfig and KafkaProducer [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13881: MINOR: fix typo of ProducerConfig and KafkaProducer
URL: https://github.com/apache/kafka/pull/13881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #13881: MINOR: fix typo of ProducerConfig and KafkaProducer
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #13881:
URL: https://github.com/apache/kafka/pull/13881#discussion_r1236988175
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -94,8 +94,8 @@ public class ProducerConfig extends AbstractConfig {
+ "batch size is under this <code>batch.size</code> setting.";
/** <code>partitioner.adaptive.partitioning.enable</code> */
- public static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable";
Review Comment:
If we want to remove (rename) this field in a future version, we can deprecate it now and introduce a new field with the correct spelling.
That might fall into KIP territory, though. @divijvaidya thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #13881: MINOR: fix typo of ProducerConfig and KafkaProducer
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #13881:
URL: https://github.com/apache/kafka/pull/13881#discussion_r1236988175
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -94,8 +94,8 @@ public class ProducerConfig extends AbstractConfig {
+ "batch size is under this <code>batch.size</code> setting.";
/** <code>partitioner.adaptive.partitioning.enable</code> */
- public static final String PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG = "partitioner.adaptive.partitioning.enable";
Review Comment:
If we want to remove this field in a future version, we can deprecate it now and introduce a new field with the correct spelling.
That might fall into KIP territory, though. @divijvaidya thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org