You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Kristen Legacy <kr...@gmail.com> on 2012/09/07 21:02:23 UTC
Review Request: RAVE-790 Add explicit close to Dialog and ModalDialog views
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6960/
-----------------------------------------------------------
Review request for rave.
Description
-------
Added close button to dialog & modalDialog views.
https://issues.apache.org/jira/browse/RAVE-790
Diffs
-----
/trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1382064
/trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1382064
Diff: https://reviews.apache.org/r/6960/diff/
Testing
-------
Thanks,
Kristen Legacy
Re: Review Request: RAVE-790 Add explicit close to Dialog and ModalDialog
views
Posted by Erin Noe-Payne <er...@mitre.org>.
> On Sept. 7, 2012, 7:12 p.m., Chris Geer wrote:
> > Kristen, this ticket was originally part of RAVE-760 where there was a comment about making the close button optional (from me). It would be preferably to find a way to make the dialog configurable in a way that would allow people to set the option when showing a dialog but I don't think we have a way to do that yet. Maybe the alternative is to have two sets of dialog configs, one with close icons and one without. The use case is if you have special processing on the close of the dialog, with this change there is no way to enforce that as far as I can see. Thoughts?
> >
> > We really need to have dialogs be more configurable at runtime. I'm doing it now through some RPC calls but it's not 100% ideal. Maybe we can come up with a better solution.
>
> Kristen Legacy wrote:
> Hey Chris! In the case of the dialog view, the user is able to close the modal by clicking on the backdrop. I can't say I see any reason why, if this action is acceptable, a close button would be any different since the modal can be closed without interacting with it's content? Adding the close button will just make it more obvious that you can do that.
>
> The modal_dialog view on the other hand, probably should have two different configurations, since leaving the modal [as they currently are] requires interaction with its content.
>
> It would definitely be ideal if they were configurable at runtime, in lieu of that though, I 'm not coming up with any other alternatives than having the additional configs.
>
> Chris Geer wrote:
> I wonder if we could put a ticket into Shindig to pass the viewParams on to the createElement method. Maybe Matt can provide some advice here...
>
> Another option would be to provide a rave API method to cache dialog configuration options to be used on opens. That wouldn't be the end of the world I guess.
There is simply no way to pass options to the popup as it stands. If we see a legitimate need for dialogs (modal and non-modal) with and without "X" close icons, then these just need to be separate popup definitions. So your default view targets will be dialog, modal_dialog, dialog_with_x, modal_dialog_with_x(you can choose better names!)
As Chris said, the more complete solution is to patch shindig so that container.views.createElementForGadget receives the viewParams object, and then have the initialization function of the popups decide whether to insert the close "x" based on a flag there.
- Erin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6960/#review11175
-----------------------------------------------------------
On Sept. 7, 2012, 7:02 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6960/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2012, 7:02 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Added close button to dialog & modalDialog views.
>
> https://issues.apache.org/jira/browse/RAVE-790
>
>
> Diffs
> -----
>
> /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1382064
> /trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1382064
>
> Diff: https://reviews.apache.org/r/6960/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>
Re: Review Request: RAVE-790 Add explicit close to Dialog and ModalDialog
views
Posted by Chris Geer <ch...@cxtsoftware.com>.
> On Sept. 7, 2012, 7:12 p.m., Chris Geer wrote:
> > Kristen, this ticket was originally part of RAVE-760 where there was a comment about making the close button optional (from me). It would be preferably to find a way to make the dialog configurable in a way that would allow people to set the option when showing a dialog but I don't think we have a way to do that yet. Maybe the alternative is to have two sets of dialog configs, one with close icons and one without. The use case is if you have special processing on the close of the dialog, with this change there is no way to enforce that as far as I can see. Thoughts?
> >
> > We really need to have dialogs be more configurable at runtime. I'm doing it now through some RPC calls but it's not 100% ideal. Maybe we can come up with a better solution.
>
> Kristen Legacy wrote:
> Hey Chris! In the case of the dialog view, the user is able to close the modal by clicking on the backdrop. I can't say I see any reason why, if this action is acceptable, a close button would be any different since the modal can be closed without interacting with it's content? Adding the close button will just make it more obvious that you can do that.
>
> The modal_dialog view on the other hand, probably should have two different configurations, since leaving the modal [as they currently are] requires interaction with its content.
>
> It would definitely be ideal if they were configurable at runtime, in lieu of that though, I 'm not coming up with any other alternatives than having the additional configs.
I wonder if we could put a ticket into Shindig to pass the viewParams on to the createElement method. Maybe Matt can provide some advice here...
Another option would be to provide a rave API method to cache dialog configuration options to be used on opens. That wouldn't be the end of the world I guess.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6960/#review11175
-----------------------------------------------------------
On Sept. 7, 2012, 7:02 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6960/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2012, 7:02 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Added close button to dialog & modalDialog views.
>
> https://issues.apache.org/jira/browse/RAVE-790
>
>
> Diffs
> -----
>
> /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1382064
> /trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1382064
>
> Diff: https://reviews.apache.org/r/6960/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>
Re: Review Request: RAVE-790 Add explicit close to Dialog and ModalDialog
views
Posted by Kristen Legacy <kr...@gmail.com>.
> On Sept. 7, 2012, 7:12 p.m., Chris Geer wrote:
> > Kristen, this ticket was originally part of RAVE-760 where there was a comment about making the close button optional (from me). It would be preferably to find a way to make the dialog configurable in a way that would allow people to set the option when showing a dialog but I don't think we have a way to do that yet. Maybe the alternative is to have two sets of dialog configs, one with close icons and one without. The use case is if you have special processing on the close of the dialog, with this change there is no way to enforce that as far as I can see. Thoughts?
> >
> > We really need to have dialogs be more configurable at runtime. I'm doing it now through some RPC calls but it's not 100% ideal. Maybe we can come up with a better solution.
Hey Chris! In the case of the dialog view, the user is able to close the modal by clicking on the backdrop. I can't say I see any reason why, if this action is acceptable, a close button would be any different since the modal can be closed without interacting with it's content? Adding the close button will just make it more obvious that you can do that.
The modal_dialog view on the other hand, probably should have two different configurations, since leaving the modal [as they currently are] requires interaction with its content.
It would definitely be ideal if they were configurable at runtime, in lieu of that though, I 'm not coming up with any other alternatives than having the additional configs.
- Kristen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6960/#review11175
-----------------------------------------------------------
On Sept. 7, 2012, 7:02 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6960/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2012, 7:02 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Added close button to dialog & modalDialog views.
>
> https://issues.apache.org/jira/browse/RAVE-790
>
>
> Diffs
> -----
>
> /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1382064
> /trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1382064
>
> Diff: https://reviews.apache.org/r/6960/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>
Re: Review Request: RAVE-790 Add explicit close to Dialog and ModalDialog
views
Posted by Chris Geer <ch...@cxtsoftware.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6960/#review11175
-----------------------------------------------------------
Kristen, this ticket was originally part of RAVE-760 where there was a comment about making the close button optional (from me). It would be preferably to find a way to make the dialog configurable in a way that would allow people to set the option when showing a dialog but I don't think we have a way to do that yet. Maybe the alternative is to have two sets of dialog configs, one with close icons and one without. The use case is if you have special processing on the close of the dialog, with this change there is no way to enforce that as far as I can see. Thoughts?
We really need to have dialogs be more configurable at runtime. I'm doing it now through some RPC calls but it's not 100% ideal. Maybe we can come up with a better solution.
- Chris Geer
On Sept. 7, 2012, 7:02 p.m., Kristen Legacy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6960/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2012, 7:02 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Added close button to dialog & modalDialog views.
>
> https://issues.apache.org/jira/browse/RAVE-790
>
>
> Diffs
> -----
>
> /trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1382064
> /trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1382064
>
> Diff: https://reviews.apache.org/r/6960/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kristen Legacy
>
>