[GitHub] villebro commented on issue #4994: Force lowercase column names for Snowflake and Oracle

[GitBox <gi...@apache.org>]

villebro commented on issue #4994: Force lowercase column names for Snowflake and Oracle
URL: https://github.com/apache/incubator-superset/pull/4994#issuecomment-388640951
 
 
   Ok, that's fine, too, as long as we're always consistently using the same API. Would the plan be to add querying methods to the `db_engine_spec`? This way we could have more control over the details later.
   
   With regards to the details on Oracle/Snowflake case logic, I think this hack works fine in for now, at least much better than if left untouched. I've actually raised the `cursor.description` vs `resultproxy.keys()` inconsistency with Snowflake and hope to get some help from them on that front, either guidance on how to use the connector or a change to it's behaviour/room for customisation of engine_params in future versions. At any rate, the current problem stems from mixing cursor with connection, so this problem should ultimately go away if all db connectivity is streamlined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org