[GitHub] [lucene-solr] zacharymorn edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

[GitBox <gi...@apache.org>]

zacharymorn edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-729389857


   > > I think we just need to resolve the "replace now or not" question?
   > 
   > I'd like to improve the testcase and use a real index on top of a combination with FSDirectory.open() wrapped by this directory. It should also test the whole BaseDirectoryTestCase testsuite on the directory, so sublass this class for the test.
   
   Updated for the test case.
   
   Since the current native code has not been "officially available" for some time now (as the cpp compilation was not available after ant migration) until the last PR that re-enables it, I feel there's very little risk to replace it now ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org