You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/14 21:31:35 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #15010: DO NOT MERGE: attempt to add Postgresql function library to Beam SQL

kennknowles commented on a change in pull request #15010:
URL: https://github.com/apache/beam/pull/15010#discussion_r651291856



##########
File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
##########
@@ -1364,6 +1364,18 @@ public void testTimestampMinusInterval() {
     checker.buildRunAndCheck();
   }
 
+  @Test
+  // More needed @SqlOperatorTest(name = CONVERT_TIMEZONE, kind = "DATETIME")
+  public void testConvertTimezone() {
+    ExpressionChecker checker =
+        new ExpressionChecker()
+            .addExpr(
+                "CONVERT_TIMEZONE('America/New York', 'UTC', TIMESTAMP '1984-04-19 01:01:58')",
+                parseTimestampWithUTCTimeZone("1984-04-19 01:01:56"));

Review comment:
       Noting that I wasn't trying to actually get the answer right - I just wanted to get it to parse, then sort out the right answer. I find timestamp instantiation while mystifying in Calcite.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org