You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "Ju@N" <ju...@gmail.com> on 2020/02/05 12:22:38 UTC

[PROPOSAL]: Include GEODE-7728 in Release 1.12.0

Hello devs,

I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
The change is basically to avoid throwing an exception and return the
correct result whenever a query has more than one condition and one of them
compares two indexed fields.
This is not a new issue but it can be hit by any user under the conditions
I've mentioned, it is also considered critical for one of the customers I
work for, thus I'm eagerly asking to include the fix in the next release.
The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
Best regards.

[1]: https://issues.apache.org/jira/browse/GEODE-7728
[2]:
https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb

-- 
Ju@N

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

Posted by Ernest Burghardt <eb...@pivotal.io>.
There appears to be consensus that this is a critical fix.

The following commit has been brought into release/1.12 as the
critical fix for GEODE-7728:

git cherry-pick -x 6e35c201ea605075433203d4e64ca887bafd8fcb

GEODE-7728 has been marked as 'resolved in' 1.12.

Regards
EB


On Wed, Feb 5, 2020 at 4:32 PM Ernest Burghardt <eb...@pivotal.io>
wrote:

> +1
>
> I'll plan to cherry-pick in the morning if there are no objections...
>
>
> On Wed, Feb 5, 2020 at 11:20 AM Ivan Godwin <ig...@pivotal.io> wrote:
>
>> +1
>>
>> On Wed, Feb 5, 2020 at 10:16 AM Nabarun Nag <nn...@pivotal.io> wrote:
>>
>> > ++
>> >
>> > On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann <am...@apache.org>
>> > wrote:
>> >
>> > > +1
>> > >
>> > > On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer <ud...@apache.com> wrote:
>> > >
>> > > > +1 - for inclusion
>> > > >
>> > > > On 2/5/20 4:22 AM, Ju@N wrote:
>> > > > > Hello devs,
>> > > > >
>> > > > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
>> > > > > The change is basically to avoid throwing an exception and return
>> the
>> > > > > correct result whenever a query has more than one condition and
>> one
>> > of
>> > > > them
>> > > > > compares two indexed fields.
>> > > > > This is not a new issue but it can be hit by any user under the
>> > > > conditions
>> > > > > I've mentioned, it is also considered critical for one of the
>> > > customers I
>> > > > > work for, thus I'm eagerly asking to include the fix in the next
>> > > release.
>> > > > > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
>> > > > > Best regards.
>> > > > >
>> > > > > [1]: https://issues.apache.org/jira/browse/GEODE-7728
>> > > > > [2]:
>> > > > >
>> > > >
>> > >
>> >
>> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

Posted by Ernest Burghardt <eb...@pivotal.io>.
+1

I'll plan to cherry-pick in the morning if there are no objections...


On Wed, Feb 5, 2020 at 11:20 AM Ivan Godwin <ig...@pivotal.io> wrote:

> +1
>
> On Wed, Feb 5, 2020 at 10:16 AM Nabarun Nag <nn...@pivotal.io> wrote:
>
> > ++
> >
> > On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann <am...@apache.org>
> > wrote:
> >
> > > +1
> > >
> > > On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer <ud...@apache.com> wrote:
> > >
> > > > +1 - for inclusion
> > > >
> > > > On 2/5/20 4:22 AM, Ju@N wrote:
> > > > > Hello devs,
> > > > >
> > > > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> > > > > The change is basically to avoid throwing an exception and return
> the
> > > > > correct result whenever a query has more than one condition and one
> > of
> > > > them
> > > > > compares two indexed fields.
> > > > > This is not a new issue but it can be hit by any user under the
> > > > conditions
> > > > > I've mentioned, it is also considered critical for one of the
> > > customers I
> > > > > work for, thus I'm eagerly asking to include the fix in the next
> > > release.
> > > > > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> > > > > Best regards.
> > > > >
> > > > > [1]: https://issues.apache.org/jira/browse/GEODE-7728
> > > > > [2]:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
> > > > >
> > > >
> > >
> >
>

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

Posted by Ivan Godwin <ig...@pivotal.io>.
+1

On Wed, Feb 5, 2020 at 10:16 AM Nabarun Nag <nn...@pivotal.io> wrote:

> ++
>
> On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann <am...@apache.org>
> wrote:
>
> > +1
> >
> > On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer <ud...@apache.com> wrote:
> >
> > > +1 - for inclusion
> > >
> > > On 2/5/20 4:22 AM, Ju@N wrote:
> > > > Hello devs,
> > > >
> > > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> > > > The change is basically to avoid throwing an exception and return the
> > > > correct result whenever a query has more than one condition and one
> of
> > > them
> > > > compares two indexed fields.
> > > > This is not a new issue but it can be hit by any user under the
> > > conditions
> > > > I've mentioned, it is also considered critical for one of the
> > customers I
> > > > work for, thus I'm eagerly asking to include the fix in the next
> > release.
> > > > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> > > > Best regards.
> > > >
> > > > [1]: https://issues.apache.org/jira/browse/GEODE-7728
> > > > [2]:
> > > >
> > >
> >
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
> > > >
> > >
> >
>

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

Posted by Nabarun Nag <nn...@pivotal.io>.
++

On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann <am...@apache.org>
wrote:

> +1
>
> On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer <ud...@apache.com> wrote:
>
> > +1 - for inclusion
> >
> > On 2/5/20 4:22 AM, Ju@N wrote:
> > > Hello devs,
> > >
> > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> > > The change is basically to avoid throwing an exception and return the
> > > correct result whenever a query has more than one condition and one of
> > them
> > > compares two indexed fields.
> > > This is not a new issue but it can be hit by any user under the
> > conditions
> > > I've mentioned, it is also considered critical for one of the
> customers I
> > > work for, thus I'm eagerly asking to include the fix in the next
> release.
> > > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> > > Best regards.
> > >
> > > [1]: https://issues.apache.org/jira/browse/GEODE-7728
> > > [2]:
> > >
> >
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
> > >
> >
>

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

Posted by Alexander Murmann <am...@apache.org>.
+1

On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer <ud...@apache.com> wrote:

> +1 - for inclusion
>
> On 2/5/20 4:22 AM, Ju@N wrote:
> > Hello devs,
> >
> > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> > The change is basically to avoid throwing an exception and return the
> > correct result whenever a query has more than one condition and one of
> them
> > compares two indexed fields.
> > This is not a new issue but it can be hit by any user under the
> conditions
> > I've mentioned, it is also considered critical for one of the customers I
> > work for, thus I'm eagerly asking to include the fix in the next release.
> > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> > Best regards.
> >
> > [1]: https://issues.apache.org/jira/browse/GEODE-7728
> > [2]:
> >
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
> >
>

Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

Posted by Udo Kohlmeyer <ud...@apache.com>.
+1 - for inclusion

On 2/5/20 4:22 AM, Ju@N wrote:
> Hello devs,
>
> I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> The change is basically to avoid throwing an exception and return the
> correct result whenever a query has more than one condition and one of them
> compares two indexed fields.
> This is not a new issue but it can be hit by any user under the conditions
> I've mentioned, it is also considered critical for one of the customers I
> work for, thus I'm eagerly asking to include the fix in the next release.
> The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> Best regards.
>
> [1]: https://issues.apache.org/jira/browse/GEODE-7728
> [2]:
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
>