You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/06/02 19:10:56 UTC

Review Request 34949: RANGER-521: updated RangerAccessReqest.getAsString() and isLeafName() to not require serviceDef argument

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34949/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, and Selvamohan Neethiraj.


Bugs: RANGER-521
    https://issues.apache.org/jira/browse/RANGER-521


Repository: ranger


Description
-------

updated RangerAccessReqest.getAsString() and isLeafName() to not require serviceDef argument


Diffs
-----

  .gitignore 7f41f0c 
  agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 253a180 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java 82c0248 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java 7c26f90 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerMutableResource.java 16ab725 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java 0a0b210 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 4219875 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 6a355ff 
  agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerResourceAccessCacheImpl.java 3388361 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 574dd5b 
  agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java ed67e8e 
  hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 5b115b2 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java 3c16c8f 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 190c241 

Diff: https://reviews.apache.org/r/34949/diff/


Testing
-------

Verified that all tests pass after this change.


Thanks,

Madhan Neethiraj


Re: Review Request 34949: RANGER-521: updated RangerAccessReqest.getAsString() and isLeafName() to not require serviceDef argument

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34949/#review86253
-----------------------------------------------------------

Ship it!


Ship It!

- Don Bosco Durai


On June 2, 2015, 5:10 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34949/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 5:10 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-521
>     https://issues.apache.org/jira/browse/RANGER-521
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> updated RangerAccessReqest.getAsString() and isLeafName() to not require serviceDef argument
> 
> 
> Diffs
> -----
> 
>   .gitignore 7f41f0c 
>   agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 253a180 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResource.java 82c0248 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java 7c26f90 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerMutableResource.java 16ab725 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java 0a0b210 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 4219875 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 6a355ff 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerResourceAccessCacheImpl.java 3388361 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 574dd5b 
>   agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java ed67e8e 
>   hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 5b115b2 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java 3c16c8f 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 190c241 
> 
> Diff: https://reviews.apache.org/r/34949/diff/
> 
> 
> Testing
> -------
> 
> Verified that all tests pass after this change.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 34949: RANGER-521: updated RangerAccessReqest.getAsString() and isLeafName() to not require serviceDef argument

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34949/#review86635
-----------------------------------------------------------

Ship it!


Ship It!

- Don Bosco Durai


On June 4, 2015, 4:07 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34949/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 4:07 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-521
>     https://issues.apache.org/jira/browse/RANGER-521
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> updated RangerAccessReqest.getAsString() and isLeafName() to not require serviceDef argument
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 095eafb 
> 
> Diff: https://reviews.apache.org/r/34949/diff/
> 
> 
> Testing
> -------
> 
> Verified that all tests pass after this change.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 34949: RANGER-521: updated RangerAccessReqest.getAsString() and isLeafName() to not require serviceDef argument

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34949/
-----------------------------------------------------------

(Updated June 4, 2015, 4:07 p.m.)


Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, and Selvamohan Neethiraj.


Changes
-------

Fix: empty resource-name in audit logs for grant/revoke


Bugs: RANGER-521
    https://issues.apache.org/jira/browse/RANGER-521


Repository: ranger


Description
-------

updated RangerAccessReqest.getAsString() and isLeafName() to not require serviceDef argument


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 095eafb 

Diff: https://reviews.apache.org/r/34949/diff/


Testing
-------

Verified that all tests pass after this change.


Thanks,

Madhan Neethiraj